From: Jingoo Han <jg1.han@samsung.com>
To: "'Mark Brown'" <broonie@kernel.org>
Cc: "'Liam Girdwood'" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"'Bengt Jonsson'" <bengt.g.jonsson@stericsson.com>,
"'Jingoo Han'" <jg1.han@samsung.com>,
"'Fengguang Wu'" <fengguang.wu@intel.com>
Subject: Re: [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf()
Date: Wed, 19 Mar 2014 09:19:17 +0900 [thread overview]
Message-ID: <001301cf4308$dd78baf0$986a30d0$%han@samsung.com> (raw)
In-Reply-To: <002f01cf3291$02c7f7e0$0857e7a0$%han@samsung.com>
On Wednesday, February 26, 2014 10:21 AM, Jingoo Han wrote:
>
> For a constant format without additional arguments, use seq_puts()
> instead of seq_printf(). Also, it fixes the following checkpatch
> warning.
>
> WARNING: Prefer seq_puts to seq_printf
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/regulator/dbx500-prcmu.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
> index f111dfb..3dd1096 100644
> --- a/drivers/regulator/dbx500-prcmu.c
> +++ b/drivers/regulator/dbx500-prcmu.c
> @@ -97,10 +97,10 @@ static int ux500_regulator_power_state_cnt_print(struct seq_file *s, void *p)
> int err;
>
> /* print power state count */
> - err = seq_printf(s, "ux500-regulator power state count: %i\n",
> - power_state_active_get());
> + err = seq_puts(s, "ux500-regulator power state count: %i\n",
> + power_state_active_get());
It makes build error with 'make ARCH=arm allmodconfig', as
Fengguang Wu reported.
drivers/regulator/dbx500-prcmu.c: In function 'ux500_regulator_power_state_cnt_print':
drivers/regulator/dbx500-prcmu.c:103:4: error: too many arguments to function 'seq_puts'
So, I will send v2 patch. Sorry for annoying you.
Thank you.
Best regards,
Jingoo Han
> if (err < 0)
> - dev_err(dev, "seq_printf overflow\n");
> + dev_err(dev, "seq_puts overflow\n");
>
> return 0;
> }
> @@ -127,9 +127,9 @@ static int ux500_regulator_status_print(struct seq_file *s, void *p)
> int i;
>
> /* print dump header */
> - err = seq_printf(s, "ux500-regulator status:\n");
> + err = seq_puts(s, "ux500-regulator status:\n");
> if (err < 0)
> - dev_err(dev, "seq_printf overflow\n");
> + dev_err(dev, "seq_puts overflow\n");
>
> err = seq_printf(s, "%31s : %8s : %8s\n", "current",
> "before", "after");
> --
> 1.7.10.4
next prev parent reply other threads:[~2014-03-19 0:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 1:19 [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Jingoo Han
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
2014-03-19 0:19 ` Jingoo Han [this message]
2014-03-19 0:26 ` [PATCH V2] " Jingoo Han
2014-03-19 10:20 ` Mark Brown
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
2014-02-26 2:10 ` Haojian Zhuang
2014-02-27 4:39 ` Mark Brown
2014-03-05 4:33 ` [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001301cf4308$dd78baf0$986a30d0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=broonie@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).