linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ben Castricum" <lk@bencastricum.nl>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.22-pre3 : SoundBlaster IDE interface missing
Date: Sat, 12 Jul 2003 18:57:49 +0200	[thread overview]
Message-ID: <001501c34896$baddd3e0$0802a8c0@pc> (raw)
In-Reply-To: 1057578275.2749.11.camel@dhcp22.swansea.linux.org.uk


> On Sul, 2003-07-06 at 17:56, Ben Castricum wrote:
> > I have one of those ancients ISA-PNP SoundBlaster cards with an
additional
> > IDE interface on it. It all worked perfectly up till 2.4.22-pre2 but
with
> > pre3 the IDE interface is no longer detected.
>
> Oops. I have redone the initialization for the ISAPnP IDE devices so its
> quite possible I got this bit wrong. I'll take a look at it
> today/tomorrow see why its vanished.

I took a look at it myself as well and it seems that the code was just
removed. This patch restores a couple of line from pre2 and fixes the
problem for me. It's diffed againts the current bk-2.4 tree.

Hope this helps,
Ben


diff -u linux/drivers/ide/ide-pnp.c linux-fix/drivers/ide/ide-pnp.c
--- linux/drivers/ide/ide-pnp.c 2003-07-12 18:03:05.000000000 +0200
+++ linux-fix/drivers/ide/ide-pnp.c     2003-07-12 18:26:13.000000000 +0200
@@ -99,7 +99,7 @@
  * Probe for ISA PnP IDE interfaces.
  */

-static void pnpide_init(int enable)
+void __init pnpide_init(int enable)
 {
        struct pci_dev *dev = NULL;
        struct pnp_dev_t *dev_type;
diff -u linux/drivers/ide/ide.c linux-fix/drivers/ide/ide.c
--- linux/drivers/ide/ide.c     2003-07-12 18:03:01.000000000 +0200
+++ linux-fix/drivers/ide/ide.c 2003-07-12 18:25:11.000000000 +0200
@@ -2318,6 +2318,12 @@
                buddha_init();
        }
 #endif /* CONFIG_BLK_DEV_BUDDHA */
+#if defined(CONFIG_BLK_DEV_ISAPNP) && defined(CONFIG_ISAPNP)
+       {
+               extern void pnpide_init(int enable);
+               pnpide_init(1);
+       }
+#endif /* CONFIG_BLK_DEV_ISAPNP */
 }

 void __init ide_init_builtin_subdrivers (void)


  reply	other threads:[~2003-07-12 16:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-06 16:56 2.4.22-pre3 : SoundBlaster IDE interface missing Ben Castricum
2003-07-07 11:44 ` Alan Cox
2003-07-12 16:57   ` Ben Castricum [this message]
2003-07-13  8:33     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001501c34896$baddd3e0$0802a8c0@pc' \
    --to=lk@bencastricum.nl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).