From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'Joao Pinto'" <Joao.Pinto@synopsys.com>,
"'Zhou Wang'" <wangzhou1@hisilicon.com>,
"'Gabriele Paoloni'" <gabriele.paoloni@huawei.com>
Subject: Re: [PATCH] pci: dwc: hisi needs PCI_HOST_COMMON
Date: Tue, 21 Mar 2017 11:48:37 -0400 [thread overview]
Message-ID: <001801d2a25a$9c742760$d55c7620$@gmail.com> (raw)
In-Reply-To: <20170321143229.3372903-1-arnd@arndb.de>
(+cc: Joao Pinto, Zhou Wang, Gabriele Paoloni)
On Tuesday, March 21, 2017 10:32 AM, Arnd Bergmann wrote:
>
> Without PCI_HOST_COMMON support enabled, we get a link error:
>
> drivers/pci/dwc/built-in.o: In function `hisi_pcie_map_bus':
> pcie-hisi.c:(.text+0x8860): undefined reference to `pci_ecam_map_bus'
> drivers/pci/dwc/built-in.o: In function `hisi_pcie_almost_ecam_probe':
> pcie-hisi.c:(.text+0x88b4): undefined reference to `pci_host_common_probe'
>
> This adds an explicit 'select', as the other users have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/pci/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig
> index dfb8a69afc28..d2d2ba5b8a68 100644
> --- a/drivers/pci/dwc/Kconfig
> +++ b/drivers/pci/dwc/Kconfig
> @@ -89,6 +89,7 @@ config PCI_HISI
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIEPORTBUS
> select PCIE_DW_HOST
> + select PCI_HOST_COMMON
> help
> Say Y here if you want PCIe controller support on HiSilicon
> Hip05 and Hip06 SoCs
> --
> 2.9.0
next prev parent reply other threads:[~2017-03-21 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 14:32 [PATCH] pci: dwc: hisi needs PCI_HOST_COMMON Arnd Bergmann
2017-03-21 15:48 ` Jingoo Han [this message]
2017-03-22 3:27 ` Zhou Wang
[not found] ` <CAK8P3a0cuu6nnxNDstq8_QiE2D139k0zyTV13TeLzcT0uLha=Q@mail.gmail.com>
2017-03-22 12:24 ` Zhou Wang
2017-04-03 21:18 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801d2a25a$9c742760$d55c7620$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).