From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423770AbcFNBya (ORCPT ); Mon, 13 Jun 2016 21:54:30 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36684 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423478AbcFNByV (ORCPT ); Mon, 13 Jun 2016 21:54:21 -0400 Reply-To: chris@lapa.com.au Subject: Re: [PATCH v2 1/4] max8903: adds documentation for device tree bindings. References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1465561970-18377-1-git-send-email-chris@lapa.com.au> <1465561970-18377-2-git-send-email-chris@lapa.com.au> <575AC5E5.3020405@samsung.com> To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Chris Lapa Message-ID: <001abdba-d10c-90d5-944f-ebeaf236eb12@lapa.com.au> Date: Tue, 14 Jun 2016 11:54:17 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <575AC5E5.3020405@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2016 11:51 PM, Krzysztof Kozlowski wrote: > On 06/10/2016 02:32 PM, Chris Lapa wrote: >> From: Chris Lapa >> >> Signed-off-by: Chris Lapa >> --- >> .../devicetree/bindings/power/max8903-charger.txt | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt > > You again skipped all of the maintainers. Your patch won't be applied. > You need to send the patch to the appropriate person so he/she could > apply it. > > From this patch: > Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS,commit_signer:9/19=47%) > Mark Rutland (maintainer:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS) > > From power suppyy tree: > Sebastian Reichel (maintainer:POWER SUPPLY > CLASS/SUBSYSTEM and DRIVERS) > Dmitry Eremin-Solenikov (maintainer:POWER SUPPLY > CLASS/SUBSYSTEM and DRIVERS) > David Woodhouse (maintainer:POWER SUPPLY > CLASS/SUBSYSTEM and DRIVERS) > > >> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt b/Documentation/devicetree/bindings/power/max8903-charger.txt >> new file mode 100644 >> index 0000000..e0b5366 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt >> @@ -0,0 +1,30 @@ >> +Maxim Semiconductor MAX8903 Battery Charger bindings >> + >> +Required properties: >> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger >> +- dc_valid: Specifies that the DC portion of the MAX8903 has been connected up >> + and that dok-gpios should be specified > > You don't need the dc_valid nor the usb_valid. If the dok-gpios are > present - use DC power. If the uok-gpios - USB power. > I did think that as well, but I didn't want to break backwards compatibility. > If both or none: print error. Its valid to have both connected. > > BTW, It would be nice if send also the user of this bindings - DTS/DTSI. I'm not sure I understand what you mean here? > > Best regards, > Krzysztof > >> + - dok-gpios: Valid DC power has been detected >> +- usb_valid: Specifies that the USB portion of the MAX8903 has been connected up >> + and that uok-gpios should be specified >> + - uok-gpios: Valid USB power has been detected >> + >> +Optional properties: >> +- cen-gpios: Charge enable pin >> +- chg-gpios: Charger status pin >> +- flt-gpios: Fault pin >> +- dcm-gpios: Current limit mode setting (DC or USB) >> +- usus-gpios: USB suspend pin >> + >> + >> +Example: >> + >> + max8903-charger { >> + compatible = "maxim,max8903-charger"; >> + dok-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; >> + flt-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; >> + chg-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; >> + cen-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; >> + dc_valid; >> + status = "okay"; >> + }; >> >