From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
"'Linux PM'" <linux-pm@vger.kernel.org>
Cc: "'Rafael J. Wysocki'" <rafael@kernel.org>,
"'Viresh Kumar'" <viresh.kumar@linaro.org>,
"'Srinivas Pandruvada'" <srinivas.pandruvada@linux.intel.com>,
"'Zhang Rui'" <rui.zhang@intel.com>,
"'LKML'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] cpufreq: Introduce target min and max frequency hints
Date: Thu, 5 Nov 2020 17:49:53 -0800 [thread overview]
Message-ID: <001b01d6b3df$21165940$63430bc0$@net> (raw)
In-Reply-To: <2233690.N3OVLkotou@kreacher>
Hi Rafael:
Thank you for this patch set.
I can not get the patch to apply.
I was trying on top on 5.10-rc2, and have been unable to determine
what other patches might need to be applied first.
On 2020.11.05 10:24 Rafael J. Wysocki wrote:
...
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq.c | 3 +++
> drivers/cpufreq/cpufreq_performance.c | 4 ++++
> drivers/cpufreq/cpufreq_powersave.c | 4 ++++
> include/linux/cpufreq.h | 16 ++++++++++++++++
I do not understand why this part says to look for 16
differences, but I can only find 2.
> 4 files changed, 27 insertions(+)
>
> Index: linux-pm/include/linux/cpufreq.h
> ===================================================================
> --- linux-pm.orig/include/linux/cpufreq.h
> +++ linux-pm/include/linux/cpufreq.h
> @@ -63,6 +63,8 @@ struct cpufreq_policy {
>
> unsigned int min; /* in kHz */
> unsigned int max; /* in kHz */
> + unsigned int target_min; /* in kHz */
> + unsigned int target_max; /* in kHz */
> unsigned int cur; /* in kHz, only needed if cpufreq
> * governors are used */
> unsigned int suspend_freq; /* freq to set during suspend */
> Index: linux-pm/drivers/cpufreq/cpufreq.c
...
Anyway, I edited the patch, deleting the include/linux/cpufreq.h part,
then it applied, as did patch 2 of 2.
I edited include/linux/cpufreq.h manually.
Issues with the powersave governor reported in [1] and [2]
are fixed. Relevant part quoted and updated below:
> In early September Doug wrote:
>> powersave governor:
>> acpi-cpufreq: good
>> intel_cpufreq hwp: bad
Now good, with this patch set.
>> intel_cpufreq no hwp: good
...
> For the powersave governor, this is what we have now:
>
> intel_cpufreq hwp == intel_pstate hwp
> intel_cpufreq no hwp == acpi-cpufreq == always minimum freq
> intel_pstate no hwp ~= acpi-cpufreq/ondemand
...
> My expectation was/is:
>
> intel_cpufreq hwp == intel_cpufreq no hwp == acpi-cpufreq == always minimum freq
And this is what we now have, with this patch set.
> intel_pstate no hwp ~= acpi-cpufreq/ondemand
> intel_pstate hwp == Unique. Say, extremely course version of ondemand.
[1] https://marc.info/?l=linux-pm&m=159769839401767&w=2
[2] https://marc.info/?l=linux-pm&m=159943780220923&w=2
... Doug
next prev parent reply other threads:[~2020-11-06 1:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 18:17 [PATCH 0/2] cpufreq: intel_pstate: Handle powersave governor correctly in the passive mode with HWP Rafael J. Wysocki
2020-11-05 18:23 ` [PATCH 1/2] cpufreq: Introduce target min and max frequency hints Rafael J. Wysocki
2020-11-06 1:49 ` Doug Smythies [this message]
2020-11-06 10:07 ` Viresh Kumar
2020-11-06 17:02 ` Rafael J. Wysocki
2020-11-09 4:39 ` Viresh Kumar
2020-11-09 12:27 ` Rafael J. Wysocki
2020-11-05 18:25 ` [PATCH 2/2] cpufreq: intel_pstate: Take target_min and target_max into account Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01d6b3df$21165940$63430bc0$@net' \
--to=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).