From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756581AbcJWJuH (ORCPT ); Sun, 23 Oct 2016 05:50:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48001 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756301AbcJWJuE (ORCPT ); Sun, 23 Oct 2016 05:50:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 722A861BE5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sricharan@codeaurora.org From: "Sricharan" To: "'Marek Szyprowski'" , , , , Cc: "'Tomeu Vizoso'" , "'Bartlomiej Zolnierkiewicz'" , "'Greg Kroah-Hartman'" , "'Kevin Hilman'" , "'Rafael J. Wysocki'" , "'Tomasz Figa'" , "'Krzysztof Kozlowski'" , "'Inki Dae'" , "'Tobias Jakobi'" , "'Luis R. Rodriguez'" , "'Kukjin Kim'" , "'Mark Brown'" , "'Lukas Wunner'" References: <1476948173-21093-1-git-send-email-m.szyprowski@samsung.com> <1476948173-21093-8-git-send-email-m.szyprowski@samsung.com> In-Reply-To: <1476948173-21093-8-git-send-email-m.szyprowski@samsung.com> Subject: RE: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm Date: Sun, 23 Oct 2016 15:19:52 +0530 Message-ID: <001e01d22d12$d2a4e990$77eebcb0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJ+uDLclmqDoXsyw4psny6anZSUigEQXHInAfnbw/OfRGMpAA== Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, >This patch uses recently introduced device dependency links to track the >runtime pm state of the master's device. This way each SYSMMU controller >is set to runtime active only when its master's device is active and can >restore or save its state instead of being activated all the time when >attached to the given master device. This way SYSMMU controllers no longer >prevents respective power domains to be turned off when master's device >is not being used. > >Signed-off-by: Marek Szyprowski >--- > drivers/iommu/exynos-iommu.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c >index 5e6d7bbf9b70..59b4f2ce4f5f 100644 >--- a/drivers/iommu/exynos-iommu.c >+++ b/drivers/iommu/exynos-iommu.c >@@ -781,10 +781,6 @@ static void exynos_iommu_detach_device(struct iommu_domain *iommu_domain, > if (!has_sysmmu(dev) || owner->domain != iommu_domain) > return; > >- list_for_each_entry(data, &owner->controllers, owner_node) { >- pm_runtime_put_sync(data->sysmmu); >- } >- > mutex_lock(&owner->rpm_lock); > > list_for_each_entry(data, &owner->controllers, owner_node) { >@@ -848,10 +844,6 @@ static int exynos_iommu_attach_device(struct iommu_domain *iommu_domain, > > mutex_unlock(&owner->rpm_lock); > >- list_for_each_entry(data, &owner->controllers, owner_node) { >- pm_runtime_get_sync(data->sysmmu); >- } >- > dev_dbg(dev, "%s: Attached IOMMU with pgtable %pa\n", __func__, > &pagetable); > >@@ -1232,6 +1224,14 @@ static int exynos_iommu_of_xlate(struct device *dev, > > list_add_tail(&data->owner_node, &owner->controllers); > data->master = dev; >+ >+ /* >+ * SYSMMU will be runtime activated via device link (dependency) to its >+ * master device, so there are no direct calls to pm_runtime_get/put >+ * in this driver. >+ */ >+ device_link_add(dev, data->sysmmu, DL_FLAG_PM_RUNTIME); >+ So in the case of master with multiple sids, this would be called multiple times for the same master ? Regards, Sricharan