From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF33C4338F for ; Wed, 11 Aug 2021 10:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E864601FD for ; Wed, 11 Aug 2021 10:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236904AbhHKKSo (ORCPT ); Wed, 11 Aug 2021 06:18:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:59049 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231684AbhHKKSn (ORCPT ); Wed, 11 Aug 2021 06:18:43 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="237118251" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="237118251" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 03:18:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="506892636" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.174]) ([10.237.72.174]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2021 03:18:17 -0700 Subject: Re: [PATCH 1/5] perf script: Fix unnecessary machine_resolve() To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-kernel@vger.kernel.org References: <20210810114813.12951-1-adrian.hunter@intel.com> <20210810114813.12951-2-adrian.hunter@intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <002d3bee-ae51-4a19-9eaa-8cdc63a97e86@intel.com> Date: Wed, 11 Aug 2021 13:18:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/21 9:25 pm, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 10, 2021 at 02:48:09PM +0300, Adrian Hunter escreveu: >> machine_resolve() may have already been called. Test for that to avoid >> calling it again unnecessarily. > > By some dlfilter function, right... > > Perhaps it would be better for machine__resolve() itself to check that? > > Probably we'll need a 'force' arg, or have __machine__resolve() that > does exactly what machine__resolve() does today and then tools wanting > to force it to avoid using whatever is 'cached'? Yes, or perhaps introduce machine__resolve_once() and thread__resolve_once() ? > > - Arnaldo > >> Signed-off-by: Adrian Hunter >> --- >> tools/perf/builtin-script.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c >> index e2e165b53499..f469354155f1 100644 >> --- a/tools/perf/builtin-script.c >> +++ b/tools/perf/builtin-script.c >> @@ -2212,7 +2212,7 @@ static int process_sample_event(struct perf_tool *tool, >> if (filter_cpu(sample)) >> goto out_put; >> >> - if (machine__resolve(machine, &al, sample) < 0) { >> + if (!al.thread && machine__resolve(machine, &al, sample) < 0) { >> pr_err("problem processing %d event, skipping it.\n", >> event->header.type); >> ret = -1; >> -- >> 2.17.1 >> >