From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Colin King <colin.king@canonical.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
Doug Ledford <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][next] RDMA/irdma: remove redundant initialization of variable val
Date: Mon, 7 Jun 2021 14:53:58 +0000 [thread overview]
Message-ID: <002eafeb137b42a8ae6782e6394c2170@intel.com> (raw)
In-Reply-To: <20210605131347.26293-1-colin.king@canonical.com>
> Subject: [PATCH][next] RDMA/irdma: remove redundant initialization of variable val
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable val is being initialized with a value that is never read, it is being
> updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/irdma/ctrl.c b/drivers/infiniband/hw/irdma/ctrl.c
> index 8bd3aecadaf6..b1023a7d0bd1 100644
> --- a/drivers/infiniband/hw/irdma/ctrl.c
> +++ b/drivers/infiniband/hw/irdma/ctrl.c
> @@ -3323,7 +3323,7 @@ __le64 *irdma_sc_cqp_get_next_send_wqe_idx(struct
> irdma_sc_cqp *cqp, u64 scratch
> */
> enum irdma_status_code irdma_sc_cqp_destroy(struct irdma_sc_cqp *cqp) {
> - u32 cnt = 0, val = 1;
> + u32 cnt = 0, val;
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
next prev parent reply other threads:[~2021-06-07 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 13:13 [PATCH][next] RDMA/irdma: remove redundant initialization of variable val Colin King
2021-06-07 14:53 ` Saleem, Shiraz [this message]
2021-06-07 23:46 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002eafeb137b42a8ae6782e6394c2170@intel.com \
--to=shiraz.saleem@intel.com \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).