From: Jingoo Han <jg1.han@samsung.com>
To: "'Peter Ujfalusi'" <peter.ujfalusi@ti.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Richard Purdie'" <rpurdie@rpsys.net>,
"'Florian Tobias Schandinat'" <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Grazvydas Ignotas'" <notasas@gmail.com>
Subject: RE: [PATCH] backlight: pandora_bl: Change TWL4030_MODULE_PWM0 to TWL_MODULE_PWM
Date: Thu, 15 Nov 2012 09:46:09 +0900 [thread overview]
Message-ID: <003f01cdc2ca$9a9bb350$cfd319f0$%han@samsung.com> (raw)
In-Reply-To: <1352891761-29561-1-git-send-email-peter.ujfalusi@ti.com>
On Wednesday, November 14, 2012 8:16 PM Peter Ujfalusi wrote
>
> TWL_MODULE_PWM is defined as:
> #define TWL_MODULE_PWM TWL4030_MODULE_PWM0
>
> Use the common module ID define here which will facilitate the upcoming
> twl-core cleanup.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC'ed Andrew Morton
It looks good.
Acked-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/pandora_bl.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/backlight/pandora_bl.c b/drivers/video/backlight/pandora_bl.c
> index 4ec3074..633b0a2 100644
> --- a/drivers/video/backlight/pandora_bl.c
> +++ b/drivers/video/backlight/pandora_bl.c
> @@ -71,8 +71,7 @@ static int pandora_backlight_update_status(struct backlight_device *bl)
> * set PWM duty cycle to max. TPS61161 seems to use this
> * to calibrate it's PWM sensitivity when it starts.
> */
> - twl_i2c_write_u8(TWL4030_MODULE_PWM0, MAX_VALUE,
> - TWL_PWM0_OFF);
> + twl_i2c_write_u8(TWL_MODULE_PWM, MAX_VALUE, TWL_PWM0_OFF);
>
> /* first enable clock, then PWM0 out */
> twl_i2c_read_u8(TWL4030_MODULE_INTBR, &r, TWL_INTBR_GPBR1);
> @@ -90,8 +89,7 @@ static int pandora_backlight_update_status(struct backlight_device *bl)
> usleep_range(2000, 10000);
> }
>
> - twl_i2c_write_u8(TWL4030_MODULE_PWM0, MIN_VALUE + brightness,
> - TWL_PWM0_OFF);
> + twl_i2c_write_u8(TWL_MODULE_PWM, MIN_VALUE + brightness, TWL_PWM0_OFF);
>
> done:
> if (brightness != 0)
> @@ -132,7 +130,7 @@ static int pandora_backlight_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, bl);
>
> /* 64 cycle period, ON position 0 */
> - twl_i2c_write_u8(TWL4030_MODULE_PWM0, 0x80, TWL_PWM0_ON);
> + twl_i2c_write_u8(TWL_MODULE_PWM, 0x80, TWL_PWM0_ON);
>
> bl->props.state |= PANDORABL_WAS_OFF;
> bl->props.brightness = MAX_USER_VALUE;
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-11-15 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:16 [PATCH] backlight: pandora_bl: Change TWL4030_MODULE_PWM0 to TWL_MODULE_PWM Peter Ujfalusi
2012-11-15 0:46 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003f01cdc2ca$9a9bb350$cfd319f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).