From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A34C433E0 for ; Fri, 5 Mar 2021 01:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5AA064F79 for ; Fri, 5 Mar 2021 01:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbhCEBuk (ORCPT ); Thu, 4 Mar 2021 20:50:40 -0500 Received: from emcscan.emc.com.tw ([192.72.220.5]:53453 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhCEBuk (ORCPT ); Thu, 4 Mar 2021 20:50:40 -0500 X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="39659207" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 05 Mar 2021 09:50:38 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(2833:0:AUTH_RELAY) (envelope-from ); Fri, 05 Mar 2021 09:50:37 +0800 (CST) Received: from 192.168.33.11 by webmail.emc.com.tw with Mail2000 ESMTP Server V7.00(2480:2:AUTH_RELAY) (envelope-from ); Fri, 05 Mar 2021 09:50:35 +0800 (CST) From: "jingle" To: "'Dmitry Torokhov'" Cc: "'linux-kernel'" , "'linux-input'" , "'phoenix'" , "'dave.wang'" , "'josh.chen'" References: <20210226073537.4926-1-jingle.wu@emc.com.tw> <1614647097.9201.jingle.wu@emc.com.tw> <004f01d7115e$3ba005e0$b2e011a0$@emc.com.tw> In-Reply-To: Subject: RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Date: Fri, 5 Mar 2021 09:50:35 +0800 Message-ID: <005401d71161$ef9b20e0$ced162a0$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGs01cKeSW+WSlGkCw6sJc3Mb/pawH5MxoQAdwxvXACK2QSBAIRtt8MAkDeqHiqdoFO8A== Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDYwMTFcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0yZDM3MjQ2Ni03ZDU1LTExZWItOGUwZi1mMDc5NTk2OWU3NWVcYW1lLXRlc3RcMmQzNzI0NjgtN2Q1NS0xMWViLThlMGYtZjA3OTU5NjllNzVlYm9keS50eHQiIHN6PSIxNDMxIiB0PSIxMzI1OTM4MjYzNTkzNjg3NzQiIGg9IjBnbUVkenFod3UvUndLN003TVhReUxmVXVraz0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Dmitry: 1. You mean to let all devices ignore skipping reset/sleep part of device initialization? 2. The test team found that some old firmware will have errors (invalid report etc...), so ELAN can only ensure that the new device can meet the newer parts. Thanks jingle -----Original Message----- From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] Sent: Friday, March 05, 2021 9:31 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Hi Jingle, On Fri, Mar 05, 2021 at 09:24:05AM +0800, jingle wrote: > HI Dmitry: > > In this case (in the newer parts behavior regarding need to reset > after powering them on), it is consistent with the original driver > behavior with any new or old device (be called > data->ops->initialize(client) : usleep(100) , etc.. , because this > times "data->quirks" is equal 0 at probe state.) You misunderstood my question. I was asking what specifically, if anything, was changed in the firmware to allow skipping reset/sleep part of device initialization on newer parts during resume process. Because of there were no specific changes I would say let's not do a quirk and change the driver to skip reset on resume. Thanks. -- Dmitry