From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751634AbeFDByb convert rfc822-to-8bit (ORCPT ); Sun, 3 Jun 2018 21:54:31 -0400 Received: from mx.socionext.com ([202.248.49.38]:35203 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbeFDBya (ORCPT ); Sun, 3 Jun 2018 21:54:30 -0400 From: "Katsuhiro Suzuki" To: "'Masahiro Yamada'" , =?utf-8?B?U3V6dWtpLCBLYXRzdWhpcm8v6Yi05pyoIOWLneWNmg==?= Cc: "Mauro Carvalho Chehab" , , "Masami Hiramatsu" , "Jassi Brar" , "linux-arm-kernel" , "Linux Kernel Mailing List" References: <20180530090946.1635-1-suzuki.katsuhiro@socionext.com> <20180530090946.1635-7-suzuki.katsuhiro@socionext.com> <005d01d3fb98$20711900$61534b00$@socionext.com> In-Reply-To: Subject: Re: [PATCH 6/8] media: uniphier: add common module of DVB adapter drivers Date: Mon, 4 Jun 2018 10:54:24 +0900 Message-ID: <005e01d3fba6$f7192700$e54b7500$@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHT9/X2UbYENkxCrkO9sDWPady0aKRMS5uAgALyEOD//3g1gIAApt9Q Content-Language: ja x-securitypolicycheck: OK by SHieldMailChecker v2.5.2 x-shieldmailcheckerpolicyversion: POLICY180220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Yamada-san, > -----Original Message----- > From: Masahiro Yamada > Sent: Monday, June 4, 2018 9:53 AM > To: Suzuki, Katsuhiro/鈴木 勝博 > Cc: Mauro Carvalho Chehab ; > linux-media@vger.kernel.org; Masami Hiramatsu ; > Jassi Brar ; linux-arm-kernel > ; Linux Kernel Mailing List > > Subject: Re: [PATCH 6/8] media: uniphier: add common module of DVB adapter drivers > > 2018-06-04 9:08 GMT+09:00 Katsuhiro Suzuki : > > Hello Yamada-san, > > > >> -----Original Message----- > >> From: Masahiro Yamada > >> Sent: Saturday, June 2, 2018 9:00 PM > >> To: Suzuki, Katsuhiro/鈴木 勝博 > >> Cc: Mauro Carvalho Chehab ; > >> linux-media@vger.kernel.org; Masami Hiramatsu ; > >> Jassi Brar ; linux-arm-kernel > >> ; Linux Kernel Mailing List > >> > >> Subject: Re: [PATCH 6/8] media: uniphier: add common module of DVB adapter drivers > >> > >> 2018-05-30 18:09 GMT+09:00 Katsuhiro Suzuki : > >> > This patch adds common module for UniPhier DVB adapter drivers > >> > that equipments tuners and demod that connected by I2C and > >> > UniPhier demux. > >> > > >> > Signed-off-by: Katsuhiro Suzuki > >> > --- > >> > drivers/media/platform/uniphier/Makefile | 5 ++ > >> > drivers/media/platform/uniphier/hsc-core.c | 8 --- > >> > .../platform/uniphier/uniphier-adapter.c | 54 +++++++++++++++++++ > >> > .../platform/uniphier/uniphier-adapter.h | 42 +++++++++++++++ > >> > 4 files changed, 101 insertions(+), 8 deletions(-) > >> > create mode 100644 drivers/media/platform/uniphier/uniphier-adapter.c > >> > create mode 100644 drivers/media/platform/uniphier/uniphier-adapter.h > >> > > >> > diff --git a/drivers/media/platform/uniphier/Makefile > >> b/drivers/media/platform/uniphier/Makefile > >> > index 0622f04d9e68..9e75ad081b77 100644 > >> > --- a/drivers/media/platform/uniphier/Makefile > >> > +++ b/drivers/media/platform/uniphier/Makefile > >> > @@ -3,3 +3,8 @@ uniphier-dvb-y += hsc-core.o hsc-ucode.o hsc-css.o hsc-ts.o > >> hsc-dma.o > >> > uniphier-dvb-$(CONFIG_DVB_UNIPHIER_LD11) += hsc-ld11.o > >> > > >> > obj-$(CONFIG_DVB_UNIPHIER) += uniphier-dvb.o > >> > + > >> > +ccflags-y += -Idrivers/media/dvb-frontends/ > >> > +ccflags-y += -Idrivers/media/tuners/ > >> > >> > >> Please add $(srctree)/ like > >> > >> ccflags-y += -I$(srctree)/drivers/media/dvb-frontends/ > >> ccflags-y += -I$(srctree)/drivers/media/tuners/ > >> > >> > >> Currently, it works $(srctree)/, > >> but I really want to rip off the build system hack. > > > > Thanks, I agree with your opinion, but other Makefiles in drivers/media use > > same hack. I don't know other way to include headers of demodulators and > > tuners... > > > > Do you have any good ideas? > > > > > > > My suggestion is to add '$(srctree)/'. > > For clarification, > > > > Bad: > > ccflags-y += -Idrivers/media/dvb-frontends/ > ccflags-y += -Idrivers/media/tuners/ > > > > Good: > > ccflags-y += -I$(srctree)/drivers/media/dvb-frontends/ > ccflags-y += -I$(srctree)/drivers/media/tuners/ > > OK, I understand. > > > > I want to fix this tree-wide, > then remove the 'addtree' from scripts/Kbuild.include > but I have not been able to find time for that. > > This is a new file, so just suggested to add '$(srctree)/' > > > > If you want to know the context: > https://patchwork.kernel.org/patch/9632347/ > Thank you, that's interesting issue... Regards, -- Katsuhiro Suzuki > > -- > Best Regards > Masahiro Yamada