From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Johannes Weiner'" <hannes@cmpxchg.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Mel Gorman'" <mgorman@suse.de>,
"'Michal Hocko'" <mhocko@suse.com>,
"'Minchan Kim'" <minchan.kim@gmail.com>,
"'Rik van Riel'" <riel@redhat.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed
Date: Fri, 03 Feb 2017 15:42:55 +0800 [thread overview]
Message-ID: <006601d27df1$228a3940$679eabc0$@alibaba-inc.com> (raw)
In-Reply-To: <20170202191957.22872-7-hannes@cmpxchg.org>
On February 03, 2017 3:20 AM Johannes Weiner wrote:
> @@ -1063,7 +1063,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> PageReclaim(page) &&
> test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> nr_immediate++;
> - goto keep_locked;
> + goto activate_locked;
Out of topic but relevant IMHO, I can't find where it is cleared by grepping:
$ grep -nr PGDAT_WRITEBACK linux-4.9/mm
linux-4.9/mm/vmscan.c:1019: test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
linux-4.9/mm/vmscan.c:1777: set_bit(PGDAT_WRITEBACK, &pgdat->flags);
It was removed in commit 1d82de618dd
("mm, vmscan: make kswapd reclaim in terms of nodes")
Is it currently maintained somewhere else, Mel and John?
thanks
Hillf
next prev parent reply other threads:[~2017-02-03 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 19:19 [PATCH 0/7] mm: vmscan: fix kswapd writeback regression v2 Johannes Weiner
2017-02-02 19:19 ` [PATCH 1/7] mm: vmscan: scan dirty pages even in laptop mode Johannes Weiner
2017-02-02 19:19 ` [PATCH 2/7] mm: vmscan: kick flushers when we encounter dirty pages on the LRU Johannes Weiner
2017-02-02 19:19 ` [PATCH 3/7] mm: vmscan: kick flushers when we encounter dirty pages on the LRU fix Johannes Weiner
2017-02-02 19:19 ` [PATCH 4/7] mm: vmscan: remove old flusher wakeup from direct reclaim path Johannes Weiner
2017-02-02 19:19 ` [PATCH 5/7] mm: vmscan: only write dirty pages that the scanner has seen twice Johannes Weiner
2017-02-02 19:19 ` [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed Johannes Weiner
2017-02-03 7:42 ` Hillf Danton [this message]
2017-02-03 15:15 ` Michal Hocko
2017-02-02 19:19 ` [PATCH 7/7] mm: vmscan: move dirty pages out of the way until they're flushed fix Johannes Weiner
2017-02-02 22:49 ` [PATCH 0/7] mm: vmscan: fix kswapd writeback regression v2 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006601d27df1$228a3940$679eabc0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).