From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C05C18E5B for ; Mon, 16 Mar 2020 18:11:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A61F20674 for ; Mon, 16 Mar 2020 18:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732296AbgCPSLg (ORCPT ); Mon, 16 Mar 2020 14:11:36 -0400 Received: from mga17.intel.com ([192.55.52.151]:23982 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732266AbgCPSLg (ORCPT ); Mon, 16 Mar 2020 14:11:36 -0400 IronPort-SDR: vfCLz/9c/Kd22IKCNyrBRWqoEckXRDTJKtP/IRZBPPgOCSKkkRnYjjh9bs1jFEblzDmXCdmMIY OP4+VrU72cSg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 11:11:35 -0700 IronPort-SDR: 2okYc3O1CkZQl90IZIRmTdtPlRU/7KTyQFVf2t/WeNbMyTWr5ITV6hM5A6Ora06zlIlgJpEpfy NHb/syst8c8A== X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="390786252" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.254.77.132]) ([10.254.77.132]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 11:11:35 -0700 From: Reinette Chatre Subject: Re: [PATCH 02/10] x86/resctrl: Remove max_delay To: James Morse , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Babu Moger References: <20200214182401.39008-1-james.morse@arm.com> <20200214182401.39008-3-james.morse@arm.com> Message-ID: <0069c11a-772c-23d8-a9f1-c8cb0e2a1c63@intel.com> Date: Mon, 16 Mar 2020 11:11:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200214182401.39008-3-james.morse@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On 2/14/2020 10:23 AM, James Morse wrote: > max_delay is used by x86's rdt_get_mem_config() as a local variable. get_mem_config() may be more appropriate since rdt_get_mem_config() does not exist, __get_mem_config_intel() would be most accurate. > Remove it, replacing it with a local variable. > > Signed-off-by: James Morse > --- Apart from the above ... Reviewed-by: Reinette Chatre Thank you Reinette