From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E945C4338F for ; Tue, 10 Aug 2021 17:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B90C60EBD for ; Tue, 10 Aug 2021 17:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbhHJRa1 (ORCPT ); Tue, 10 Aug 2021 13:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhHJRa0 (ORCPT ); Tue, 10 Aug 2021 13:30:26 -0400 X-Greylist: delayed 169 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 10 Aug 2021 10:30:04 PDT Received: from mail3.marcant.net (mail3.marcant.net [IPv6:2a00:f88:0:3011:217:14:160:188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26ABEC0613C1 for ; Tue, 10 Aug 2021 10:30:04 -0700 (PDT) Received: from [192.168.180.1] (port=45942 helo=admins.marcant.net) by mail3.marcant.net with esmtp (Exim 4.94.2) (envelope-from ) id 1mDVWt-0002jU-0R; Tue, 10 Aug 2021 19:27:07 +0200 Received: from vmh.kalnet.hooya.de (unknown [192.168.203.15]) by admins.marcant.net (Postfix) with ESMTPA id 5195E2808A2; Tue, 10 Aug 2021 19:27:06 +0200 (CEST) Subject: Re: [RFC net-next 2/3] net: dsa: qca8k: enable assisted learning on CPU port To: DENG Qingfang , Vladimir Oltean Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Russell King , "open list:NETWORKING DRIVERS" , open list , Ansuel Smith , Jonathan McDowell , =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= , Christian Lamparter , Nishka Dasgupta , John Crispin , Stefan Lippers-Hollmann , Hannu Nyman , Imran Khan , Frank Wunderlich , Nick Lowe References: <20210807120726.1063225-1-dqfext@gmail.com> <20210807120726.1063225-3-dqfext@gmail.com> <20210807222555.y6r7qxhdyy6d3esx@skbuf> <20210808160503.227880-1-dqfext@gmail.com> From: Andre Valentin Organization: MarcanT AG Message-ID: <0072b721-7520-365d-26ef-a2ad70117ac2@marcant.net> Date: Tue, 10 Aug 2021 19:27:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210808160503.227880-1-dqfext@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 08, 2021 at 1805, DENG Qingfang wrote: > On Sun, Aug 08, 2021 at 01:25:55AM +0300, Vladimir Oltean wrote: >> On Sat, Aug 07, 2021 at 08:07:25PM +0800, DENG Qingfang wrote: >>> Enable assisted learning on CPU port to fix roaming issues. >> >> 'roaming issues' implies to me it suffered from blindness to MAC >> addresses learned on foreign interfaces, which appears to not be true >> since your previous patch removes hardware learning on the CPU port >> (=> hardware learning on the CPU port was supported, so there were no >> roaming issues) The issue is with a wifi AP bridged into dsa and previously learned addresses. Test setup: We have to wifi APs a and b(with qca8k). Client is on AP a. The qca8k switch in AP b sees also the broadcast traffic from the client and takes the address into its fdb. Now the client roams to AP b. The client starts DHCP but does not get an IP. With tcpdump, I see the packets going through the switch (ap->cpu port->ethernet port) and they arrive at the DHCP server. It responds, the response packet reaches the ethernet port of the qca8k, and is not forwarded. After about 3 minutes the fdb entry in the qca8k on AP b is "cleaned up" and the client can immediately get its IP from the DHCP server. I hope this helps understanding the background.