From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C71C10F00 for ; Fri, 6 Mar 2020 07:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2443420728 for ; Fri, 6 Mar 2020 07:47:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725951AbgCFHrB (ORCPT ); Fri, 6 Mar 2020 02:47:01 -0500 Received: from emcscan.emc.com.tw ([192.72.220.5]:36998 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbgCFHrB (ORCPT ); Fri, 6 Mar 2020 02:47:01 -0500 X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="34725026" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 06 Mar 2020 15:46:58 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(149861:0:AUTH_RELAY) (envelope-from ); Fri, 06 Mar 2020 15:47:01 +0800 (CST) Received: from 192.168.55.71 by webmail.emc.com.tw with Mail2000 ESMTPA Server V7.00(2487:0:AUTH_LOGIN) (envelope-from ); Fri, 06 Mar 2020 15:47:00 +0800 (CST) From: "Johnny.Chuang" To: "'Peter Hutterer'" , "'Johnny Chuang'" Cc: "'Dmitry Torokhov'" , "'Benjamin Tissoires'" , , , "'Jennifer Tsai'" , "'James Chen'" , "'Paul Liang'" , "'Jeff Chuang'" References: <1582766000-23023-1-git-send-email-johnny.chuang.emc@gmail.com> <20200227223608.GB1087116@jelly> In-Reply-To: Subject: RE: [PATCH] Input: elants_i2c - Report resolution information for touch major Date: Fri, 6 Mar 2020 15:46:55 +0800 Message-ID: <007301d5f38b$68683080$39389180$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKWH33oxoD7nuWwmg1Q/5rISp31bAHeLyTrpqWIE/CABka78IAAFcSw Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDUwMTBcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1hNWQ2ODkyZS01ZjdlLTExZWEtYmE5Yi03YzVjZjg3NDk0NzhcYW1lLXRlc3RcYTVkNjg5MzAtNWY3ZS0xMWVhLWJhOWItN2M1Y2Y4NzQ5NDc4Ym9keS50eHQiIHN6PSIyODk1IiB0PSIxMzIyNzk1NDQxNTEzNTE5MTgiIGg9IlJ2R2I0NDJFVitGN0dna1VRTjJPU3IyYTRqOD0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > -----Original Message----- > > > From: Peter Hutterer [mailto:peter.hutterer@who-t.net] > > > Sent: Friday, February 28, 2020 6:36 AM > > > To: Johnny Chuang > > > Cc: Dmitry Torokhov; Benjamin Tissoires; > > > linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; Johnny > > > Chuang; Jennifer Tsai; James Chen; Paul Liang; Jeff Chuang > > > Subject: Re: [PATCH] Input: elants_i2c - Report resolution > > > information for touch major > > > > > > On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > > > > From: Johnny Chuang > > > > > > > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR > > event. > > > > This information is needed in showing pressure/width radius. > > > > > > > > Signed-off-by: Johnny Chuang > > > > --- > > > > drivers/input/touchscreen/elants_i2c.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/input/touchscreen/elants_i2c.c > > > b/drivers/input/touchscreen/elants_i2c.c > > > > index 4911799..14c577c 100644 > > > > --- a/drivers/input/touchscreen/elants_i2c.c > > > > +++ b/drivers/input/touchscreen/elants_i2c.c > > > > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct > > > > i2c_client > > > *client, > > > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > > > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > > > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > > > > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > > > > > official resolution for absinfo is "units per mm", so a value of 3 > > > would mean 3mm, is that correct? > > > > Correct. > > This resolution (1 unit/mm) is for all elan I2C touchscreen devices, > > including the touchscreen devices in the future. > > This information is from our firmware members. > > Hi Peter / Benjamin, > Could you help to review and approve this patch? > Hi Peter / Benjamin, HP project Mordin mass production on 2020/3/10. ODM needs to upgrade new image with this patch to verify. Because ODM can not get the image link from Google, already delay verify schedule. Please help to review and approve this patch ASAP. Thank you very much. > > > > > > > > Not that it matters too much, since touch major is already all over > > > the place and needs userspace overrides for every device but it'd be > > > nice to at least make this useful out of the box on one device class. > > > > > > Reviewed-by: Peter Hutterer > > > > > > otherwise > > > > > > Cheers, > > > Peter > > > > > > > > > > > error = input_register_device(ts->input); > > > > if (error) { > > > > -- > > > > 2.7.4 > > > >