From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932117AbdABHpy (ORCPT ); Mon, 2 Jan 2017 02:45:54 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34154 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755088AbdABHpv (ORCPT ); Mon, 2 Jan 2017 02:45:51 -0500 Subject: Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file To: Shawn Guo References: <20161209010436.7994-1-woogyom.kim@gmail.com> <20161209010436.7994-2-woogyom.kim@gmail.com> <20170102065239.GC20956@dragon> <450d89c7-7459-6369-3a07-cc60d70de0db@gmail.com> <20170102074155.GG20956@dragon> Cc: Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Milo Kim Message-ID: <0077a5bb-60ea-a4d6-0cab-08bdfdd4f57d@gmail.com> Date: Mon, 2 Jan 2017 16:45:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170102074155.GG20956@dragon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/2017 04:41 PM, Shawn Guo wrote: > On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: >> >> On 01/02/2017 03:52 PM, Shawn Guo wrote: >>>> + panel { >>>> + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; >>> "avic, tm097tdh02" is an undocumented compatible. >>> >> >> AVIC TM097TDH02 panel is compatible with Hannstar HSD100PXN1, so I >> reuse it. It's the same rule as the usage of imx6q I2C controller. >> >> i2c2: i2c@021a4000 { >> compatible = "fsl,imx6q-i2c", "fsl,imx21-i2c"; >> }; > > Okay. Drop the space in the middle of the compatible. Thanks for all your feedback. Please let me submit the v4 later. Best regards, Milo