From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210AbcI1FhD (ORCPT + 2 others); Wed, 28 Sep 2016 01:37:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:45587 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcI1Fgw (ORCPT ); Wed, 28 Sep 2016 01:36:52 -0400 X-AuditID: cbfee61b-f79d46d000004922-c5-57eb56f1affe From: Kiwoong Kim To: "'Martin K. Petersen'" , subhashj@codeaurora.org Cc: 'Zang Leigang' , vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org References: <20160825093919.5936-1-zangleigang@hisilicon.com> <9e470819d1cfcead5966e37c00f53967@codeaurora.org> In-reply-to: Subject: RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR Date: Wed, 28 Sep 2016 14:36:49 +0900 Message-id: <007b01d2194a$4f3567a0$eda036e0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ks_c_5601-1987 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-index: AQInpDpzR75MhygeaB6ZcgPfNVPEmAJoggX2AsuoBEsCbW6OZZ+mPFcQ Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t9jAd2PYa/DDfbsU7BYNTHP4vKuOWwW 01blWHRf38Fmsfz4PyaLG4t3slnsWFhl8W/NdDYHDo/Lfb1MHjtn3WX3eDx3I7vHg0ObWTw+ Pr3F4vF5k1wAW5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4p kGdkgAYcnAPcg5X07RLcMhZNbGYt2MtTcbn9IlsD4wKuLkZODgkBE4lVv3+wQ9hiEhfurWfr YuTiEBJYyigx9dFNVgjnPaPE3ylPmUGq2AQ0JZ7enMoEYosIBEjs+7qGEaSIWWA/o0T3k8NQ HW8YJc78bmMEqeIUMJT4cGwLUAc7h7CAh8TVbJAoi4CqxOkPm9hAbF4BS4kF11+yQtiCEj8m 32MBsZkFDCTez+pjhbDlJTavecsMcamCxO5PR1khbnCTuNOygw2iRkRi34t3jBMYhWYhGTUL yahZSEbNQtKygJFlFaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZw7D6T3sF4eJf7IUYB DkYlHt4V+a/ChVgTy4orcw8xSnAwK4nw7gh5HS7Em5JYWZValB9fVJqTWnyI0RTo2YnMUqLJ +cC0klcSb2hibmJubGBhbmlpYqQkzts4+1m4kEB6YklqdmpqQWoRTB8TB6dUA+MKJ07+eeeW f7i3Reme/+fd9+4WxZ10616zMec1t3LUI8GAALltD88v9WfkSFh6tWfFRPsJehrr52f7fSnt q1BtvOtc8CInMOKJo9aqk7/37KjtuuCsc+/3snCV/qwDxTYH+Y4E3Drq720o+ZvrwIdfa856 MHHpnM7U+5WyK+LrM8fdt/4+e2+uxFKckWioxVxUnAgAEzIT0vMCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, Martin. I think that the patch is correct. UFS spec says "The Data Segment area is empty" for Read Descriptor. I have been using similar code with it and it works. That have been already applied in Android kernel. Reviewed-by: Kiwoong Kim Regards. > -----Original Message----- > From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- > owner@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Wednesday, September 28, 2016 2:14 PM > To: subhashj@codeaurora.org > Cc: Zang Leigang; vinholikatti@gmail.com; jejb@linux.vnet.ibm.com; > martin.petersen@oracle.com; linux-scsi@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-scsi-owner@vger.kernel.org > Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR > > >>>>> "Subhash" == subhashj writes: > > Subhash> Looks good to me. > > > - /* Data segment length */ > > - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( > > - 0, 0, len >> 8, (u8)len); > > + /* Data segment length only need for WRITE_DESC */ > > + if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC) > > + ucd_req_ptr->header.dword_2 = > > + UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len); > > + else > > + ucd_req_ptr->header.dword_2 = 0; > > What about READ_DESC? > > -- > Martin K. Petersen Oracle Linux Engineering > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html