From: Chanho Park <chanho61.park@samsung.com>
To: "'Stephen Warren'" <swarren@nvidia.com>,
"'Linus Walleij'" <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: RE: [PATCH] pinctrl: Fix pinconf_pins_show iteration
Date: Sat, 07 Jan 2012 12:51:48 +0900 [thread overview]
Message-ID: <008001ccccef$ae75fd80$0b61f880$%park@samsung.com> (raw)
In-Reply-To: <1325882311-7504-1-git-send-email-swarren@nvidia.com>
> -----Original Message-----
> From: Stephen Warren [mailto:swarren@nvidia.com]
> Sent: Saturday, January 07, 2012 5:39 AM
> To: Linus Walleij
> Cc: linux-kernel@vger.kernel.org; Chanho Park; Stephen Warren
> Subject: [PATCH] pinctrl: Fix pinconf_pins_show iteration
>
> Commit 706e852 "pinctrl: correct a offset while enumerating pins"
> modified the variable used by pinconf_pin_show()'s for loop, but didn't
> update the for loop test expression.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/pinctrl/pinconf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index 1259872..1892a37 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -236,7 +236,7 @@ static int pinconf_pins_show(struct seq_file *s,
> void *what)
> seq_puts(s, "Format: pin (name): pinmux setting array\n");
>
> /* The pin number can be retrived from the pin controller
> descriptor */
> - for (i = 0; pin < pctldev->desc->npins; i++) {
> + for (i = 0; i < pctldev->desc->npins; i++) {
> struct pin_desc *desc;
>
> pin = pctldev->desc->pins[i].number;
> --
> 1.7.0.4
Oh, I missed it.
Thank you for refining it.
Best Regards,
Chanho Park
next prev parent reply other threads:[~2012-01-07 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 20:38 [PATCH] pinctrl: Fix pinconf_pins_show iteration Stephen Warren
2012-01-07 3:51 ` Chanho Park [this message]
2012-01-10 9:16 ` Linus Walleij
2012-01-19 17:52 ` Stephen Warren
2012-01-19 18:32 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008001ccccef$ae75fd80$0b61f880$%park@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).