linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "James Stevenson" <james@stev.org>
To: "Philippe Troin" <phil@fifi.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.19: oops in ide-scsi
Date: Thu, 26 Sep 2002 09:51:12 +0100	[thread overview]
Message-ID: <008201c26539$ddd4fea0$0cfea8c0@ezdsp.com> (raw)
In-Reply-To: <87vg4tk8h5.fsf@ceramic.fifi.org>

as far as i can tell if you change the code as you suggested
it may very possible screw over the ide system.
you suggested

if (status & ERR_STAT && rq)
    rq->errors++;

which still calls idescsi_end_request
which first line uses rq again which would
cause an opps again.

in idescsi_end_request first lines are.

if (rq->cmd != IDESCSI_PC_RQ) {
    ide_end_request (uptodate, hwgroup);
    return;
}

but as far as i can tell idescsi_end_request needs
to be called or the ide drive is left in an unkown state


----- Original Message -----
From: "Philippe Troin" <phil@fifi.org>
To: "James Stevenson" <james@stev.org>
Cc: <linux-kernel@vger.kernel.org>
Sent: Wednesday, September 25, 2002 11:30 PM
Subject: Re: 2.4.19: oops in ide-scsi


> James Stevenson <james@stev.org> writes:
>
> > Hi
> >
> > then i belive there are other possible problems which may by
> > just as bad
>
> Can you elaborate?
>
> Phil.



      reply	other threads:[~2002-09-26  8:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-24  1:08 Philippe Troin
2002-09-24 18:26 ` James Stevenson
2002-09-24 21:00   ` Philippe Troin
2002-09-24 21:41     ` James Stevenson
2002-09-25 16:46       ` Philippe Troin
2002-09-25 18:18         ` James Stevenson
2002-09-25 22:30           ` Philippe Troin
2002-09-26  8:51             ` James Stevenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='008201c26539$ddd4fea0$0cfea8c0@ezdsp.com' \
    --to=james@stev.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phil@fifi.org \
    --subject='Re: 2.4.19: oops in ide-scsi' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).