From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604AbbIQMUH (ORCPT ); Thu, 17 Sep 2015 08:20:07 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:46580 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbIQMUF (ORCPT ); Thu, 17 Sep 2015 08:20:05 -0400 X-AuditID: cbfee61b-f79d56d0000048c5-e5-55faafe99be3 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1442336146-82492-1-git-send-email-jaegeuk@kernel.org> <1442336146-82492-2-git-send-email-jaegeuk@kernel.org> In-reply-to: <1442336146-82492-2-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time Date: Thu, 17 Sep 2015 20:19:06 +0800 Message-id: <009901d0f143$28f593b0$7ae0bb10$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQNgbjMG9hrXNhSP9O/P9dvOclGIpgG/FiQ3mxOnm+A= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t9jAd2X63+FGqyaYmTxZP0sZotLi9wt 9uw9yWJxedccNgcWj02rOtk8di/4zOTxeZNcAHMUl01Kak5mWWqRvl0CV8a0EzfYC9YIVByZ cI2pgXEDbxcjJ4eEgInEvOtb2SBsMYkL99YD2VwcQgJLGSXaD/xigXBeMUr8WrCABaSKTUBF YnnHfyYQW0RATaJ33xQwm1kgU2JC/wv2LkYOoIZqiRVPK0DCnALOEqtObAdrFRaIk3h55D4r iM0ioCqx/uJmsDivgKXE1r49bBC2oMSPyfdYIEZqSazfeRxqvLzE5jVvmSEOVZDYcfY1I8QJ VhKL3j1ihKgRl9h45BbLBEahWUhGzUIyahaSUbOQtCxgZFnFKJFakFxQnJSea5SXWq5XnJhb XJqXrpecn7uJERz+z6R3MB7e5X6IUYCDUYmHV8HlV6gQa2JZcWXuIUYJDmYlEV71BUAh3pTE yqrUovz4otKc1OJDjNIcLErivLIrn4UKCaQnlqRmp6YWpBbBZJk4OKUaGEs+GekbHfHZMEtr X0+GXL1Gju4BXrm/IlLeLwSTXE59OmgqbFLKPWWV/R7TyXJlUp9u/qss9K07E83OIcjSqLfn f8XGLTuaPb+tYPufu2l/NbfUQW93+fVPzS87P/XNsJv6unt+bPNHvTPbz57JMZa7Efnbut9G an+disaep85bk6IN95RtVGIpzkg01GIuKk4EAOSrvmd7AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Wednesday, September 16, 2015 12:56 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time > > As comment says, we don't need to call f2fs_lock_op in write_inode to prevent > from producing dirty node pages all the time. > That happens only when there is not enough free sections and we can avoid that > by calling balance_fs in prior to that. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 35aae65..0fc4d02 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -296,16 +296,12 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc) > return 0; > > /* > - * We need to lock here to prevent from producing dirty node pages > + * We need to balance fs here to prevent from producing dirty node pages > * during the urgent cleaning time when runing out of free sections. > */ > - f2fs_lock_op(sbi); > - update_inode_page(inode); > - f2fs_unlock_op(sbi); > - > - if (wbc) > - f2fs_balance_fs(sbi); f2fs_balance_fs was moved here intentionally by Jin Xu in commit 92c4342fb72a ("f2fs: avoid writing inode redundantly when creating a file") to avoid redundantly inode page submitting, I was confused since I didn't know all history here. So, should we change the position of f2fs_balance_fs? Thanks, > + f2fs_balance_fs(sbi); > > + update_inode_page(inode); > return 0; > } > > -- > 2.1.1 > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel