From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753423AbcKPQ40 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 11:56:26 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:34060 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752679AbcKPQ4Z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 11:56:25 -0500
Subject: Re: [PATCH] mtd: nand: nandsim: fix error check
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>
References: <1479251395-3100-1-git-send-email-sudipm.mukherjee@gmail.com>
 <0ad0b3d4-bde6-57ab-6856-de771ade3c32@gmail.com> <582C1041.7040809@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
From: Marek Vasut <marek.vasut@gmail.com>
Message-ID: <009a3016-3fe9-bda0-feb7-7d2cc132b091@gmail.com>
Date: Wed, 16 Nov 2016 17:56:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <582C1041.7040809@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>>> a pointer on success. They do not return the error value with ERR_PTR.
>>> So we should not check the return with IS_ERR_OR_NULL, instead we
>>> should just check for NULL.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>> ---
>>>   drivers/mtd/nand/nandsim.c | 9 +++------
>>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
>>> index c76287a..9b0d79a 100644
>>> --- a/drivers/mtd/nand/nandsim.c
>>> +++ b/drivers/mtd/nand/nandsim.c
>>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct
>>> nandsim *dev)
>>>   {
>>>       struct nandsim_debug_info *dbg = &dev->dbg;
>>>       struct dentry *dent;
>>> -    int err;
>>> +    int err = -ENODEV;
>>
>> Why don't you just nuke the err altogether and just return -ENODEV ?
> 
> That was the first version which i made and discarded before sending. I
> will go and find it now.

Why did you discard it ?

-- 
Best regards,
Marek Vasut