* [PATCH] ide-probe does not set removable flag for ide-floppy devices
@ 2001-12-13 23:06 Kevin P. Fleming
2001-12-14 20:28 ` Marcelo Tosatti
2001-12-28 2:06 ` Dave Jones
0 siblings, 2 replies; 3+ messages in thread
From: Kevin P. Fleming @ 2001-12-13 23:06 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel, andre
Small patch, relative to 2.4.17-pre8, but should apply to any recent version
diff -urN -X dontdiff linux/drivers/ide/ide-probe.c
linux-new/drivers/ide/ide-probe.c
--- linux/drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001
+++ linux-new/drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001
@@ -122,6 +122,7 @@
printk("cdrom or floppy?, assuming ");
if (drive->media != ide_cdrom) {
printk ("FLOPPY");
+ drive->removable = 1;
break;
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ide-probe does not set removable flag for ide-floppy devices
2001-12-13 23:06 [PATCH] ide-probe does not set removable flag for ide-floppy devices Kevin P. Fleming
@ 2001-12-14 20:28 ` Marcelo Tosatti
2001-12-28 2:06 ` Dave Jones
1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2001-12-14 20:28 UTC (permalink / raw)
To: Kevin P. Fleming; +Cc: linux-kernel, andre
Queued for 2.4.18pre...
Thanks
On Thu, 13 Dec 2001, Kevin P. Fleming wrote:
> Small patch, relative to 2.4.17-pre8, but should apply to any recent version
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ide-probe does not set removable flag for ide-floppy devices
2001-12-13 23:06 [PATCH] ide-probe does not set removable flag for ide-floppy devices Kevin P. Fleming
2001-12-14 20:28 ` Marcelo Tosatti
@ 2001-12-28 2:06 ` Dave Jones
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jones @ 2001-12-28 2:06 UTC (permalink / raw)
To: Kevin P. Fleming; +Cc: marcelo, linux-kernel, andre, axboe
On Thu, Dec 13, 2001 at 04:06:39PM -0700, Kevin P. Fleming wrote:
> Small patch, relative to 2.4.17-pre8, but should apply to any recent version
>
> diff -urN -X dontdiff linux/drivers/ide/ide-probe.c
> linux-new/drivers/ide/ide-probe.c
> --- linux/drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001
> +++ linux-new/drivers/ide/ide-probe.c Sun Dec 9 11:41:15 2001
> @@ -122,6 +122,7 @@
> printk("cdrom or floppy?, assuming ");
> if (drive->media != ide_cdrom) {
> printk ("FLOPPY");
> + drive->removable = 1;
> break;
> }
> }
<nitpick old mails time>
To me, this looks like it would make more sense to set this to 1 _before_
the switch statement, and set to 0 as necessary, as most of the cases
look removable to me. Should cut out a few lines of code, and also mark
things like ide-tape as removable in the process too. Or is this not
desired behaviour for some reason ?
Dave.
--
Dave Jones. http://www.codemonkey.org.uk
SuSE Labs.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-12-28 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-13 23:06 [PATCH] ide-probe does not set removable flag for ide-floppy devices Kevin P. Fleming
2001-12-14 20:28 ` Marcelo Tosatti
2001-12-28 2:06 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).