From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751599AbbIQMZY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 08:25:24 -0400
Received: from mailout1.samsung.com ([203.254.224.24]:41369 "EHLO
	mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751121AbbIQMZV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 08:25:21 -0400
X-AuditID: cbfee61a-f79a06d000005c6f-4e-55fab12f4753
From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org
References: <1441936062-69511-1-git-send-email-jaegeuk@kernel.org>
 <20150911224550.GA73045@jaegeuk-mac02.mot.com>
 <20150915165215.GA82346@jaegeuk-mac02.mot.com>
 <000901d0f068$1a1bd100$4e537300$@samsung.com>
 <20150916175715.GA99097@jaegeuk-mac02.mot.com>
In-reply-to: <20150916175715.GA99097@jaegeuk-mac02.mot.com>
Subject: RE: [f2fs-dev] [PATCH v4] f2fs crypto: allocate buffer for decrypting
 filename
Date: Thu, 17 Sep 2015 20:24:27 +0800
Message-id: <009c01d0f143$eb324ef0$c196ecd0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-index: AQIcqRROTsUGAcZ1T+ANEpu2yzVoxwGvRw5hAUHHch8CKHgE/wFxFUq9nXQo/DA=
Content-language: zh-cn
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsVy+t9jQV2Djb9CDSY2Mls8WT+L2eLSIneL
	PXtPslhc3jWHzWLBxkeMDqwem1Z1snnsXvCZyePzJrkA5igum5TUnMyy1CJ9uwSujKMnfrIX
	/BWs+H19A1MD4yb+LkZODgkBE4meHR/ZIGwxiQv31gPZXBxCArMYJU5d2MIC4bxilDix+QAz
	SBWbgIrE8o7/TCC2iICaRO++KUwgRcwCjYwSC65OBCsSEmhlkpgxPRfE5hSwlrh2bCdjFyMH
	h7BApMSHRX4gJouAqsSiJjmQCl4BS4mmn1uYIGxBiR+T77GA2MwCWhLrdx5ngrDlJTavecsM
	caiCxI6zrxkhTvCTmP13K1S9uMTGI7dYJjAKzUIyahaSUbOQjJqFpGUBI8sqRonUguSC4qT0
	XMO81HK94sTc4tK8dL3k/NxNjOBIeCa1g/HgLvdDjAIcjEo8vAouv0KFWBPLiitzDzFKcDAr
	ifCqLwAK8aYkVlalFuXHF5XmpBYfYpTmYFES55Vd+SxUSCA9sSQ1OzW1ILUIJsvEwSnVwJih
	ZHtCk+vNhexp1yuf3d6kw9N5wIHz7Iu/PVKLIjr/RSafY5jsH8Efr2sRm/hH0kNhdcxl/7SC
	t7uOJDrn+DIKG7tcVZ2+VJ5r2mKJMxHzkr4bcv+5Mon/Up/N0uKIJ7enzjgqm2Jb9G7Xqq23
	GN2tXLmWii0wyutfsdendKm8zHW3V0azspVYijMSDbWYi4oTATR1zMaAAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Thursday, September 17, 2015 1:57 AM
> To: Chao Yu
> Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net; stable@vger.kernel.org
> Subject: Re: [f2fs-dev] [PATCH v4] f2fs crypto: allocate buffer for decrypting filename
> 
> Thanks Chao,
> 
> Change log from v3:
>   o enhance the code with proper error handling
> 
> Change log from v1:
>   o fix wrong pointer assignment
> 
> Chang log from v2:
>   o add one more missing call path: f2fs_encrypted_follow_link
> 
> From efdbbbb4c9bb6519e3c10ec5081a2dcdbaca81d2 Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Thu, 3 Sep 2015 13:38:23 -0700
> Subject: [PATCH] f2fs crypto: allocate buffer for decrypting filename
> 
> We got dentry pages from high_mem, and its address space directly goes into the
> decryption path via f2fs_fname_disk_to_usr.
> But, sg_init_one assumes the address is not from high_mem, so we can get this
> panic since it doesn't call kmap_high but kunmap_high is triggered at the end.
> 
> kernel BUG at ../../../../../../kernel/mm/highmem.c:290!
> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
> ...
>  (kunmap_high+0xb0/0xb8) from [<c0114534>] (__kunmap_atomic+0xa0/0xa4)
>  (__kunmap_atomic+0xa0/0xa4) from [<c035f028>] (blkcipher_walk_done+0x128/0x1ec)
>  (blkcipher_walk_done+0x128/0x1ec) from [<c0366c24>] (crypto_cbc_decrypt+0xc0/0x170)
>  (crypto_cbc_decrypt+0xc0/0x170) from [<c0367148>] (crypto_cts_decrypt+0xc0/0x114)
>  (crypto_cts_decrypt+0xc0/0x114) from [<c035ea98>] (async_decrypt+0x40/0x48)
>  (async_decrypt+0x40/0x48) from [<c032ca34>] (f2fs_fname_disk_to_usr+0x124/0x304)
>  (f2fs_fname_disk_to_usr+0x124/0x304) from [<c03056fc>] (f2fs_fill_dentries+0xac/0x188)
>  (f2fs_fill_dentries+0xac/0x188) from [<c03059c8>] (f2fs_readdir+0x1f0/0x300)
>  (f2fs_readdir+0x1f0/0x300) from [<c0218054>] (vfs_readdir+0x90/0xb4)
>  (vfs_readdir+0x90/0xb4) from [<c0218418>] (SyS_getdents64+0x64/0xcc)
>  (SyS_getdents64+0x64/0xcc) from [<c0105ba0>] (ret_fast_syscall+0x0/0x30)
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao2.yu@samsung.com>