* [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration
@ 2022-01-15 7:24 Christophe JAILLET
2022-01-17 20:06 ` Dave Jiang
2022-03-11 9:51 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-01-15 7:24 UTC (permalink / raw)
To: Dave Jiang, Vinod Koul
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dmaengine
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/dma/idxd/init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 08a5f4310188..993a5dcca24f 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -604,8 +604,6 @@ static int idxd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
dev_dbg(dev, "Set DMA masks\n");
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
- if (rc)
- rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (rc)
goto err;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration
2022-01-15 7:24 [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration Christophe JAILLET
@ 2022-01-17 20:06 ` Dave Jiang
2022-03-11 9:51 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2022-01-17 20:06 UTC (permalink / raw)
To: Christophe JAILLET, Vinod Koul; +Cc: linux-kernel, kernel-janitors, dmaengine
On 1/15/2022 12:24 AM, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks.
> ---
> drivers/dma/idxd/init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 08a5f4310188..993a5dcca24f 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -604,8 +604,6 @@ static int idxd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> dev_dbg(dev, "Set DMA masks\n");
> rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> - if (rc)
> - rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> if (rc)
> goto err;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration
2022-01-15 7:24 [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-17 20:06 ` Dave Jiang
@ 2022-03-11 9:51 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-03-11 9:51 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: Dave Jiang, linux-kernel, kernel-janitors, dmaengine
On 15-01-22, 08:24, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
> Simplify code and remove some dead code accordingly.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-11 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 7:24 [PATCH] dmaengine: idxd: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-17 20:06 ` Dave Jiang
2022-03-11 9:51 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).