From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
lee.jones@linaro.org, daniel.thompson@linaro.org
Cc: dmurphy@ti.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tomi.valkeinen@ti.com
Subject: Re: [PATCH v8 1/5] leds: populate the device's of_node when possible
Date: Fri, 4 Oct 2019 23:08:34 +0200 [thread overview]
Message-ID: <00cf59d0-cc34-a69b-be61-66647c5c4ec6@gmail.com> (raw)
In-Reply-To: <20191003082812.28491-2-jjhiblot@ti.com>
Hi Jean,
On 10/3/19 10:28 AM, Jean-Jacques Hiblot wrote:
> If initialization data is available and its fwnode is actually a of_node,
> store this information in the led device's structure. This will allow the
> device to use or provide OF-based API such (devm_xxx).
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> drivers/leds/led-class.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 647b1263c579..c2167b66b61f 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -276,8 +276,11 @@ int led_classdev_register_ext(struct device *parent,
> mutex_unlock(&led_cdev->led_access);
> return PTR_ERR(led_cdev->dev);
> }
> - if (init_data && init_data->fwnode)
> + if (init_data && init_data->fwnode) {
> led_cdev->dev->fwnode = init_data->fwnode;
> + if (is_of_node(init_data->fwnode))
This check is made inside to_of_node() macro so here we
need only below assignment.
> + led_cdev->dev->of_node = to_of_node(init_data->fwnode);
> + }
>
> if (ret)
> dev_warn(parent, "Led %s renamed to %s due to name collision",
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-10-04 21:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 8:28 [PATCH v8 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-03 8:28 ` [PATCH v8 1/5] leds: populate the device's of_node when possible Jean-Jacques Hiblot
2019-10-04 21:08 ` Jacek Anaszewski [this message]
2019-10-03 8:28 ` [PATCH v8 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-03 10:42 ` Sebastian Reichel
2019-10-03 12:47 ` Jean-Jacques Hiblot
2019-10-03 17:43 ` Jacek Anaszewski
2019-10-03 18:35 ` Mark Brown
2019-10-03 19:21 ` Jacek Anaszewski
2019-10-03 19:41 ` Mark Brown
2019-10-03 20:27 ` Should regulator core support parsing OF based fwnode? (was: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put()) Jacek Anaszewski
2019-10-04 10:12 ` Should regulator core support parsing OF based fwnode? Jean-Jacques Hiblot
2019-10-04 11:39 ` Should regulator core support parsing OF based fwnode? (was: Re: [PATCH v8 2/5] leds: Add of_led_get() and led_put()) Mark Brown
2019-10-04 13:33 ` Should regulator core support parsing OF based fwnode? Jean-Jacques Hiblot
2019-10-04 14:40 ` Mark Brown
2019-10-04 15:13 ` Jean-Jacques Hiblot
2019-10-04 15:58 ` Mark Brown
2019-10-04 16:12 ` Jean-Jacques Hiblot
2019-10-04 17:42 ` Mark Brown
2019-10-04 20:55 ` Jacek Anaszewski
2019-10-03 8:28 ` [PATCH v8 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-03 10:47 ` Sebastian Reichel
2019-10-03 8:28 ` [PATCH v8 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-03 11:17 ` Sebastian Reichel
2019-10-03 8:28 ` [PATCH v8 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-10-03 11:47 ` Sebastian Reichel
2019-10-03 17:23 ` Jean-Jacques Hiblot
2019-10-03 11:40 ` [PATCH v8 0/5] Add a generic driver for LED-based backlight Lee Jones
2019-10-08 19:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00cf59d0-cc34-a69b-be61-66647c5c4ec6@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).