From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9A4C07E97 for ; Sat, 3 Jul 2021 09:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21A396144A for ; Sat, 3 Jul 2021 09:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbhGCJki (ORCPT ); Sat, 3 Jul 2021 05:40:38 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:46190 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229977AbhGCJki (ORCPT ); Sat, 3 Jul 2021 05:40:38 -0400 Received: from omf08.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id EC976101A3244; Sat, 3 Jul 2021 09:38:03 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA id 60B691A29FE; Sat, 3 Jul 2021 09:38:02 +0000 (UTC) Message-ID: <00de2918fb9bfc46d330a72c535892d8ab992483.camel@perches.com> Subject: Re: [PATCH] ACPICA: fix if condition From: Joe Perches To: gushengxian , robert.moore@intel.com, erik.kaneda@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, devel@acpica.org, linux-kernel@vger.kernel.org, gushengxian Date: Sat, 03 Jul 2021 02:38:01 -0700 In-Reply-To: <20210703091218.650202-1-gushengxian507419@gmail.com> References: <20210703091218.650202-1-gushengxian507419@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 60B691A29FE X-Stat-Signature: i6ecosg6rgzwagjcnhqdoy6xdkhtdqnp X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/eBocd42y4w2i2SvyF/lBhyz4B2Rynd40= X-HE-Tag: 1625305082-867487 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-07-03 at 02:12 -0700, gushengxian wrote: > From: gushengxian > > Fix if condition. A few more of these... drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, ret, battery)) drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, ret, battery)) drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_START, &ret, param)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_STOP, &ret, param)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, &ret, battery)) { drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, &ret, battery)) {