From: <pillair@codeaurora.org>
To: "'Stephen Boyd'" <swboyd@chromium.org>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <mathieu.poirier@linaro.org>,
<ohad@wizery.com>, <p.zabel@pengutronix.de>, <robh+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sibis@codeaurora.org>,
<mpubbise@codeaurora.org>, <kuabhs@chromium.org>
Subject: RE: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS
Date: Tue, 16 Nov 2021 23:19:05 +0530 [thread overview]
Message-ID: <00ea01d7db12$43b6d9b0$cb248d10$@codeaurora.org> (raw)
In-Reply-To: <CAE-0n52effcajLwjOY_v-pjp68ytkb-zo4R9EHp3CQi=yB8nPQ@mail.gmail.com>
> -----Original Message-----
> From: Stephen Boyd <swboyd@chromium.org>
> Sent: Tuesday, November 16, 2021 5:13 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org;
> bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; ohad@wizery.com;
> p.zabel@pengutronix.de; robh+dt@kernel.org
> Cc: linux-arm-msm@vger.kernel.org; linux-remoteproc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> sibis@codeaurora.org; mpubbise@codeaurora.org; kuabhs@chromium.org
> Subject: Re: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for
> sc7280 WPSS
>
> Quoting Rakesh Pillai (2021-11-02 06:44:33)
> > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
> b/drivers/remoteproc/qcom_q6v5_adsp.c
> > index 098362e6..e2e8d33 100644
> > --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> > @@ -435,12 +571,22 @@ static int adsp_probe(struct platform_device
> *pdev)
> > if (!desc)
> > return -EINVAL;
> >
> > + firmware_name = desc->firmware_name;
> > + ret = of_property_read_string(pdev->dev.of_node, "firmware-
> name",
>
> Is this documented in the binding? If not, please add it.
Hi Stephen,
"firmware-name" is already documented in the bindings.
Thanks,
Rakesh Pillai.
next prev parent reply other threads:[~2021-11-16 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 13:44 [PATCH v8 0/3] Add support for sc7280 WPSS PIL loading Rakesh Pillai
2021-11-02 13:44 ` [PATCH v8 1/3] dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML Rakesh Pillai
2021-11-12 18:41 ` Rob Herring
2021-11-15 23:40 ` Stephen Boyd
2021-11-02 13:44 ` [PATCH v8 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support Rakesh Pillai
2021-11-12 18:41 ` Rob Herring
2021-11-15 23:41 ` Stephen Boyd
2021-11-02 13:44 ` [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS Rakesh Pillai
2021-11-15 23:43 ` Stephen Boyd
2021-11-16 17:49 ` pillair [this message]
2021-11-16 23:53 ` Stephen Boyd
2021-11-16 22:54 ` Stephen Boyd
2021-11-17 6:31 ` Rakesh Pillai
2021-11-17 6:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ea01d7db12$43b6d9b0$cb248d10$@codeaurora.org' \
--to=pillair@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kuabhs@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mpubbise@codeaurora.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).