From: <Claudiu.Beznea@microchip.com>
To: <conor@kernel.org>
Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <daniel.lezcano@linaro.org>,
<tglx@linutronix.de>, <wim@linux-watchdog.org>,
<linux@roeck-us.net>, <sebastian.reichel@collabora.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml
Date: Fri, 26 May 2023 04:45:15 +0000 [thread overview]
Message-ID: <00fb5057-cbae-528f-3440-6dbb3e65c7da@microchip.com> (raw)
In-Reply-To: <20230525-renewal-proposal-9620d5520437@spud>
On 25.05.2023 20:10, Conor Dooley wrote:
> On Thu, May 25, 2023 at 03:55:58PM +0300, Claudiu Beznea wrote:
>> Convert Atmel PIT to YAML. Along with it clock binding has been added as
>> the driver enables it to ensure proper hardware functionality.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> .../devicetree/bindings/arm/atmel-sysregs.txt | 6 ---
>> .../bindings/timer/atmel,at91sam9260-pit.yaml | 51 +++++++++++++++++++
>> 2 files changed, 51 insertions(+), 6 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> index 67a66bf74895..7024839c5da2 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
>> @@ -4,12 +4,6 @@ Chipid required properties:
>> - compatible: Should be "atmel,sama5d2-chipid" or "microchip,sama7g5-chipid"
>> - reg : Should contain registers location and length
>>
>> -PIT Timer required properties:
>> -- compatible: Should be "atmel,at91sam9260-pit"
>> -- reg: Should contain registers location and length
>> -- interrupts: Should contain interrupt for the PIT which is the IRQ line
>> - shared across all System Controller members.
>> -
>> PIT64B Timer required properties:
>> - compatible: Should be "microchip,sam9x60-pit64b"
>> - reg: Should contain registers location and length
>> diff --git a/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml b/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml
>> new file mode 100644
>> index 000000000000..f304cd68acd5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/timer/atmel,at91sam9260-pit.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel Periodic Interval Timer (PIT)
>> +
>> +maintainers:
>> + - Claudiu Beznea <claudiu.beznea@microchip.com>
>> +
>> +description:
>> + Atmel periodic interval timer provides the operating system’s scheduler
>> + interrupt. It is designed to offer maximum accuracy and efficient management,
>> + even for systems with long response time.
>> +
>> +properties:
>> + compatible:
>> + const: atmel,at91sam9260-pit
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + description:
>> + Contain interrupt for the PIT which is the IRQ line shared across all
>> + System Controller members.
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - clocks
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/at91.h>
>> +
>> + pit: timer@fffffe40 {
>> + compatible = "atmel,at91sam9260-pit";
>> + reg = <0xfffffe40 0x10>;
>> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> make dt_binding_check W=1 -j 30 DT_SCHEMA_FILES=atmel,at91sam9260-pit.yaml
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dts
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC_CHK Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dtb
> Error: Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dts:26.29-30 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/timer/atmel,at91sam9260-pit.example.dtb] Error 1
> make: *** [Makefile:1512: dt_binding_check] Error 2
>
> Think you're missing the header for IRQ_TYPE_LEVEL_HIGH
>
Well, I messed this series... I had the impression I've tested all these.
Sorry for the noise.
next prev parent reply other threads:[~2023-05-26 4:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 12:55 [PATCH 0/5] dt-bindings: timer: AT91 convert to YAML Claudiu Beznea
2023-05-25 12:55 ` [PATCH 1/5] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml Claudiu Beznea
2023-05-25 17:10 ` Conor Dooley
2023-05-26 4:45 ` Claudiu.Beznea [this message]
2023-05-26 1:43 ` Rob Herring
2023-05-25 12:55 ` [PATCH 2/5] ARM: dts: at91: sama7g5: keep only microchip,sam9x60-pit64b compatible for pit64b Claudiu Beznea
2023-05-25 12:56 ` [PATCH 3/5] dt-bindings: timer: microchip,sam9x60-pit64b: convert to yaml Claudiu Beznea
2023-05-25 17:14 ` Conor Dooley
2023-05-26 4:47 ` Claudiu.Beznea
2023-05-26 6:23 ` Conor Dooley
2023-05-26 6:41 ` Claudiu.Beznea
2023-05-26 7:55 ` Conor Dooley
2023-06-08 20:17 ` Rob Herring
2023-05-25 12:56 ` [PATCH 4/5] dt-bindings: watchdog: atmel,at91rm9200-wdt: " Claudiu Beznea
2023-05-25 17:15 ` Conor Dooley
2023-05-26 1:43 ` Rob Herring
2023-05-25 12:56 ` [PATCH 5/5] dt-bindings: timer: atmel,at91rm9200-st: " Claudiu Beznea
2023-05-25 17:27 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fb5057-cbae-528f-3440-6dbb3e65c7da@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).