From: Saeed Mahameed <saeedm@mellanox.com>
To: "schnelle@linux.ibm.com" <schnelle@linux.ibm.com>,
Feras Daoud <ferasda@mellanox.com>,
Alex Vesker <valex@mellanox.com>
Cc: Eran Ben Elisha <eranbe@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/1] net/mlx5: Fix failing fw tracer allocation on s390
Date: Wed, 8 Apr 2020 19:36:07 +0000 [thread overview]
Message-ID: <00fc95b9c6f5da7ec5844b9eccf4488d4a37efd8.camel@mellanox.com> (raw)
In-Reply-To: <20200407080130.34472-2-schnelle@linux.ibm.com>
On Tue, 2020-04-07 at 10:01 +0200, Niklas Schnelle wrote:
> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> kzalloc()
> allocation as done for the firmware tracer will always fail.
>
> Looking at mlx5_fw_tracer_save_trace(), it is actually the driver
> itself
> that copies the debug data into the trace array and there is no need
> for
> the allocation to be contiguous in physical memory. We can therefor
> use
> kvzalloc() instead of kzalloc() and get rid of the large contiguous
> allcoation.
>
This looks fine and very straight forward.. i don't expect any issue
with this.
Please provide a proper "Fixes:" tag and resubmit to net without the
[RFC].
Thanks
next prev parent reply other threads:[~2020-04-08 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 8:01 [RFC 0/1] net/mlx5: Failing fw tracer allocation on s390 Niklas Schnelle
2020-04-07 8:01 ` [RFC 1/1] net/mlx5: Fix failing " Niklas Schnelle
2020-04-08 19:36 ` Saeed Mahameed [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-18 16:44 [RFC 0/1] net/mlx5: Failing " Niklas Schnelle
2020-03-18 16:44 ` [RFC 1/1] net/mlx5: Fix failing " Niklas Schnelle
2020-03-18 17:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fc95b9c6f5da7ec5844b9eccf4488d4a37efd8.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=ferasda@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).