From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7DCC433EF for ; Sat, 21 May 2022 06:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240067AbiEUGLr (ORCPT ); Sat, 21 May 2022 02:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238998AbiEUGLn (ORCPT ); Sat, 21 May 2022 02:11:43 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D2E3CA45; Fri, 20 May 2022 23:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653113501; x=1684649501; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=c9C8hLHfq/Cq33w3vBjg6IKzvKol9+r0WnU0BYTso/w=; b=o9JnXrhsldFpqx0EeGYFBhNWkkoOJUTofz8grjhx2etots3OIxqYCIAU 3KDRcYbsIA0cP8FemHdAA5Lb3bQQQyVstfnHufvR/xK7DzDclirctalLN 7j7j96wQft3NTcN59mOLYQ3SUxRfeP9sBP+KCsKFgvSZ97fzi+PO0Aehm 8=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 20 May 2022 23:11:40 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 23:11:40 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 20 May 2022 23:11:39 -0700 Received: from [10.79.43.230] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 20 May 2022 23:11:37 -0700 Subject: Re: [PATCH 1/2 V2] remoteproc: core: Export the rproc coredump APIs To: Yogesh Lal , CC: , , , Siddharth Gupta References: <1652181930-22212-1-git-send-email-quic_ylal@quicinc.com> From: Sibi Sankar Message-ID: <00fe8f66-fa11-05aa-5ba4-05880783e7dd@quicinc.com> Date: Sat, 21 May 2022 11:41:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1652181930-22212-1-git-send-email-quic_ylal@quicinc.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/22 4:55 PM, Yogesh Lal wrote: > From: Siddharth Gupta > > The remoteproc coredump APIs are currently only part of the internal > remoteproc header. This prevents the remoteproc platform drivers from > using these APIs when needed. This change moves the rproc_coredump() > and rproc_coredump_cleanup() APIs to the linux header and marks them > as exported symbols. > > Signed-off-by: Siddharth Gupta Reviewed-by: Sibi Sankar > Signed-off-by: Yogesh Lal > --- > drivers/remoteproc/remoteproc_coredump.c | 2 ++ > drivers/remoteproc/remoteproc_internal.h | 4 ---- > include/linux/remoteproc.h | 4 ++++ > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c > index aee657c..aa45b68 100644 > --- a/drivers/remoteproc/remoteproc_coredump.c > +++ b/drivers/remoteproc/remoteproc_coredump.c > @@ -32,6 +32,7 @@ void rproc_coredump_cleanup(struct rproc *rproc) > kfree(entry); > } > } > +EXPORT_SYMBOL(rproc_coredump_cleanup); > > /** > * rproc_coredump_add_segment() - add segment of device memory to coredump > @@ -327,6 +328,7 @@ void rproc_coredump(struct rproc *rproc) > */ > wait_for_completion(&dump_state.dump_done); > } > +EXPORT_SYMBOL(rproc_coredump); > > /** > * rproc_coredump_using_sections() - perform coredump using section headers > diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h > index a328e63..a492a41 100644 > --- a/drivers/remoteproc/remoteproc_internal.h > +++ b/drivers/remoteproc/remoteproc_internal.h > @@ -49,10 +49,6 @@ extern struct class rproc_class; > int rproc_init_sysfs(void); > void rproc_exit_sysfs(void); > > -/* from remoteproc_coredump.c */ > -void rproc_coredump_cleanup(struct rproc *rproc); > -void rproc_coredump(struct rproc *rproc); > - > #ifdef CONFIG_REMOTEPROC_CDEV > void rproc_init_cdev(void); > void rproc_exit_cdev(void); > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index 83c09ac..b8c8c3a 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -673,6 +673,10 @@ void rproc_shutdown(struct rproc *rproc); > int rproc_detach(struct rproc *rproc); > int rproc_set_firmware(struct rproc *rproc, const char *fw_name); > void rproc_report_crash(struct rproc *rproc, enum rproc_crash_type type); > + > +/* from remoteproc_coredump.c */ > +void rproc_coredump_cleanup(struct rproc *rproc); > +void rproc_coredump(struct rproc *rproc); > void rproc_coredump_using_sections(struct rproc *rproc); > int rproc_coredump_add_segment(struct rproc *rproc, dma_addr_t da, size_t size); > int rproc_coredump_add_custom_segment(struct rproc *rproc, >