linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	syzbot+87829a10073277282ad1@syzkaller.appspotmail.com,
	Pekka Enberg <penberg@kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
	Linux-MM <linux-mm@kvack.org>
Subject: Re: WARNING: kmalloc bug in input_mt_init_slots
Date: Mon, 24 Sep 2018 15:08:15 +0000	[thread overview]
Message-ID: <010001660c1fafb2-6d0dc7e1-d898-4589-874c-1be1af94e22d-000000@email.amazonses.com> (raw)
In-Reply-To: <CACT4Y+YOb6M=xuPG64PAvd=0bcteicGtwQO60CevN_V67SJ=MQ@mail.gmail.com>

On Sun, 23 Sep 2018, Dmitry Vyukov wrote:

> What was the motivation behind that WARNING about large allocations in
> kmalloc? Why do we want to know about them? Is the general policy that
> kmalloc calls with potentially large size requests need to use NOWARN?
> If this WARNING still considered useful? Or we should change it to
> pr_err?

In general large allocs should be satisfied by the page allocator. The
slab allocators are used for allocating and managing small objects. The
page allocator has mechanisms to deal with large objects (compound pages,
multiple page sized allocs etc).


  reply	other threads:[~2018-09-24 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 17:24 WARNING: kmalloc bug in input_mt_init_slots syzbot
2018-09-21 17:52 ` Dmitry Torokhov
2018-09-23 16:33   ` Dmitry Vyukov
2018-09-24 15:08     ` Christopher Lameter [this message]
2018-09-24 15:18       ` Dmitry Vyukov
2018-09-24 15:55         ` Christopher Lameter
2018-09-24 18:41           ` Dmitry Torokhov
2018-09-25  7:39             ` Dmitry Vyukov
2018-09-25 14:04               ` Christopher Lameter
2018-09-27 13:07                 ` Dmitry Vyukov
2018-09-27 14:16                   ` Christopher Lameter
2018-09-27 14:28                     ` Dmitry Vyukov
2018-09-27 15:22                       ` Christopher Lameter
2018-09-27 15:29                         ` Dmitry Vyukov
2018-09-27 15:47                           ` Christopher Lameter
2018-09-27 14:35             ` Matthew Wilcox
2018-10-17  0:09               ` Dmitry Torokhov
2018-10-17 15:35                 ` Christopher Lameter
2018-10-17 15:43                   ` Dmitry Torokhov
2018-10-17 15:53                     ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010001660c1fafb2-6d0dc7e1-d898-4589-874c-1be1af94e22d-000000@email.amazonses.com \
    --to=cl@linux.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dvyukov@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=syzbot+87829a10073277282ad1@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).