From: Christopher Lameter <cl@linux.com>
To: Pengfei Li <lpf.vector@gmail.com>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, guro@fb.com
Subject: Re: [PATCH v5 0/7] mm, slab: Make kmalloc_info[] contain all types of names
Date: Mon, 16 Sep 2019 16:04:06 +0000 [thread overview]
Message-ID: <0100016d3ad11d18-fb812791-af73-43aa-b430-ba1889f1a85c-000000@email.amazonses.com> (raw)
In-Reply-To: <20190916144558.27282-1-lpf.vector@gmail.com>
On Mon, 16 Sep 2019, Pengfei Li wrote:
> The name of KMALLOC_NORMAL is contained in kmalloc_info[].name,
> but the names of KMALLOC_RECLAIM and KMALLOC_DMA are dynamically
> generated by kmalloc_cache_name().
>
> Patch1 predefines the names of all types of kmalloc to save
> the time spent dynamically generating names.
>
> These changes make sense, and the time spent by new_kmalloc_cache()
> has been reduced by approximately 36.3%.
This is time spend during boot and does not affect later system
performance.
> Time spent by new_kmalloc_cache()
> (CPU cycles)
> 5.3-rc7 66264
> 5.3-rc7+patch_1-3 42188
Ok. 15k cycles during boot saved. So we save 5 microseconds during bootup?
The current approach was created with the view on future setups allowing a
dynamic configuration of kmalloc caches based on need. I.e. ZONE_DMA may
not be needed once the floppy driver no longer makes use of it.
next prev parent reply other threads:[~2019-09-16 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 14:45 [PATCH v5 0/7] mm, slab: Make kmalloc_info[] contain all types of names Pengfei Li
2019-09-16 14:45 ` [PATCH v5 1/7] " Pengfei Li
2019-09-16 14:45 ` [PATCH v5 2/7] mm, slab: Remove unused kmalloc_size() Pengfei Li
2019-09-16 14:45 ` [PATCH v5 3/7] mm, slab_common: Use enum kmalloc_cache_type to iterate over kmalloc caches Pengfei Li
2019-09-16 14:45 ` [PATCH v5 4/7] mm, slab: Return ZERO_SIZE_ALLOC for zero sized kmalloc requests Pengfei Li
2019-09-16 14:45 ` [PATCH v5 5/7] mm, slab_common: Make kmalloc_caches[] start at size KMALLOC_MIN_SIZE Pengfei Li
2019-09-16 14:45 ` [PATCH v5 6/7] mm, slab_common: Initialize the same size of kmalloc_caches[] Pengfei Li
2019-09-16 14:45 ` [PATCH v5 7/7] mm, slab_common: Modify kmalloc_caches[type][idx] to kmalloc_caches[idx][type] Pengfei Li
2019-09-16 15:52 ` Christopher Lameter
2019-09-23 0:40 ` [mm, slab_common] c5e1edaa1a: BUG:unable_to_handle_page_fault_for_address kernel test robot
2019-09-16 16:04 ` Christopher Lameter [this message]
2019-09-17 13:11 ` [PATCH v5 0/7] mm, slab: Make kmalloc_info[] contain all types of names Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0100016d3ad11d18-fb812791-af73-43aa-b430-ba1889f1a85c-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lpf.vector@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).