LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: bjorn.andersson@linaro.org, robh+dt@kernel.org,
	ulf.hansson@linaro.org, rnayak@codeaurora.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	mark.rutland@arm.com, swboyd@chromium.org, dianders@chromium.org
Subject: [PATCH 1/6] soc: qcom: rpmhpd: Set 'active_only' for active only power domains
Date: Mon, 18 Nov 2019 17:40:02 +0000
Message-ID: <0101016e7f9998d8-877e9166-8b6a-4530-ab66-3c88002e1db4-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <20191118173944.27043-1-sibis@codeaurora.org>

From: Douglas Anderson <dianders@chromium.org>

The 'active_only' attribute was accidentally never set to true for any
power domains meaning that all the code handling this attribute was
dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets
this right.

Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 drivers/soc/qcom/rpmhpd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 5741ec3fa814c..51850cc68b701 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
 
 static struct rpmhpd sdm845_mx_ao = {
 	.pd = { .name = "mx_ao", },
+	.active_only = true,
 	.peer = &sdm845_mx,
 	.res_name = "mx.lvl",
 };
@@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
 
 static struct rpmhpd sdm845_cx_ao = {
 	.pd = { .name = "cx_ao", },
+	.active_only = true,
 	.peer = &sdm845_cx,
 	.parent = &sdm845_mx_ao.pd,
 	.res_name = "cx.lvl",
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


       reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191118173944.27043-1-sibis@codeaurora.org>
2019-11-18 17:40 ` Sibi Sankar [this message]
2019-11-20  2:39   ` Bjorn Andersson
2019-11-20 12:14     ` Sibi Sankar
2019-11-18 17:40 ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Sibi Sankar
2019-11-20  3:57   ` Rajendra Nayak
     [not found]   ` <9eb5e99f-836b-01a6-8b5c-d1fffd1a482b@codeaurora.org>
2019-11-20 12:15     ` Sibi Sankar
2019-12-03 21:54   ` Rob Herring
2019-11-18 17:40 ` [PATCH 3/6] soc: qcom: rpmhpd: Add SM8150 RPMH power-domains Sibi Sankar
2019-11-20  2:31   ` Bjorn Andersson
2019-11-20  4:02   ` Rajendra Nayak
     [not found]   ` <896c7edd-c511-3cdf-7281-01c894facc3b@codeaurora.org>
2019-11-20 12:16     ` Sibi Sankar
2019-11-18 17:40 ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Sibi Sankar
2019-11-20  2:31   ` Bjorn Andersson
2019-12-03 21:55   ` Rob Herring
2019-11-18 17:40 ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Sibi Sankar
2019-11-18 17:40 ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Sibi Sankar
2019-12-12  7:39   ` Bjorn Andersson
2019-12-13 15:31     ` Sibi Sankar
     [not found] ` <0101016e7f99aa17-22b1062e-9922-40e4-ae7e-8b91210bb12c-000000@us-west-2.amazonses.com>
2019-11-19 18:50   ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Stephen Boyd
2019-11-20 12:08     ` Sibi Sankar
     [not found] ` <0101016e7f99b9a0-6c4e46e3-ff77-4cc1-95f6-9561975eedc4-000000@us-west-2.amazonses.com>
2019-11-19 18:51   ` [PATCH 3/6] soc: qcom: rpmhpd: Add SM8150 RPMH power-domains Stephen Boyd
     [not found] ` <0101016e7f99ca93-ab6c1c1c-e20d-48ca-ab03-b8da0890fca8-000000@us-west-2.amazonses.com>
2019-11-19 18:51   ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Stephen Boyd
     [not found] ` <0101016e7f99df8a-05504a3e-9962-4255-94e0-706e8186cd0a-000000@us-west-2.amazonses.com>
2019-11-19 18:52   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Stephen Boyd
2019-11-20 12:09     ` Sibi Sankar
     [not found] ` <0101016e7f99eaca-e623ce91-3e2a-40ae-bf2d-647a786aa7d7-000000@us-west-2.amazonses.com>
2019-11-19 18:52   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Stephen Boyd
     [not found] ` <0101016e7f99ad2b-2bce2fac-2f02-4b3f-ac64-09942f7251ea-000000@us-west-2.amazonses.com>
2019-11-20  2:29   ` [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 Bjorn Andersson
     [not found] ` <0101016e7f99dc94-4513a473-16b3-418a-86cf-a89322016215-000000@us-west-2.amazonses.com>
2019-11-20  2:33   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Bjorn Andersson
     [not found] ` <0101016e7f99efe5-cee866e3-7031-4ecf-a8a6-4b247e9e69ff-000000@us-west-2.amazonses.com>
2019-11-20  2:35   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Bjorn Andersson
     [not found] ` <20191118173944.27043-5-sibis@codeaurora.org>
2019-11-20  4:10   ` [PATCH 4/6] dt-bindings: power: Add rpmh power-domain bindings for sc7180 Rajendra Nayak
     [not found] ` <20191118173944.27043-6-sibis@codeaurora.org>
2019-11-20  4:10   ` [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains Rajendra Nayak
     [not found] ` <20191118173944.27043-7-sibis@codeaurora.org>
2019-11-20  4:12   ` [PATCH 6/6] arm64: dts: sm8150: Add rpmh power-domain node Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101016e7f9998d8-877e9166-8b6a-4530-ab66-3c88002e1db4-000000@us-west-2.amazonses.com \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git