LKML Archive on lore.kernel.org
 help / color / Atom feed
From: sibis@codeaurora.org
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jonathan Marek <jonathan@marek.ca>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Mark Rutland <mark.rutland@arm.com>,
	p.zabel@pengutronix.de, MSM <linux-arm-msm@vger.kernel.org>,
	linux-remoteproc@vger.kernel.org,
	DTML <devicetree@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Andy Gross <agross@kernel.org>
Subject: Re: [PATCH 14/16] arm64: dts: qcom: msm8998: Add ADSP, MPSS and SLPI nodes
Date: Tue, 19 Nov 2019 12:29:31 +0000
Message-ID: <0101016e83a3aae0-2f25d2f3-6014-4992-9b40-d8716962215b-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <CAOCk7Nr=Up1LP+-XB7tnoM=XwK+YysDMq8EqyhCLx=WA+eW9PA@mail.gmail.com>

On 2019-11-19 03:37, Jeffrey Hugo wrote:
> On Mon, Nov 18, 2019 at 2:45 PM Sibi Sankar <sibis@codeaurora.org> 
> wrote:
>> 
>> This patch adds ADSP, MPSS and SLPI nodes for MSM8998 SoCs.
>> 
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi |   8 ++
>>  arch/arm64/boot/dts/qcom/msm8998.dtsi     | 122 
>> ++++++++++++++++++++++
>>  2 files changed, 130 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi 
>> b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
>> index 5f101a20a20a2..29e0c2e988e4b 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
>> @@ -23,6 +23,14 @@
>>         };
>>  };
>> 
>> +&adsp_pas {
>> +       status = "okay";
>> +};
>> +
>> +&slpi_pas {
> 
> "b" comes before "s", no?

will re-order it in the next
re-spin.

> 
>> +       status = "okay";
>> +};
>> +
>>  &blsp1_uart3 {
>>         status = "okay";
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi 
>> b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 707673e3cf28a..dd1dc35e87b63 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -337,6 +337,73 @@
>>                 };
>>         };
>> 
>> +       adsp_pas: remoteproc-adsp {
>> +               compatible = "qcom,msm8998-adsp-pas";
>> +
>> +               interrupts-extended = <&intc GIC_SPI 162 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&adsp_smp2p_in 0 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&adsp_smp2p_in 1 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&adsp_smp2p_in 2 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&adsp_smp2p_in 3 
>> IRQ_TYPE_EDGE_RISING>;
>> +               interrupt-names = "wdog", "fatal", "ready",
>> +                                 "handover", "stop-ack";
>> +
>> +               clocks = <&xo>;
>> +               clock-names = "xo";
>> +
>> +               memory-region = <&adsp_mem>;
>> +
>> +               qcom,smem-states = <&adsp_smp2p_out 0>;
>> +               qcom,smem-state-names = "stop";
>> +
>> +               power-domains = <&rpmpd MSM8998_VDDCX>;
>> +               power-domain-names = "cx";
>> +
>> +               status = "disabled";
>> +
>> +               glink-edge {
>> +                       interrupts = <GIC_SPI 157 
>> IRQ_TYPE_EDGE_RISING>;
>> +                       label = "lpass";
>> +                       qcom,remote-pid = <2>;
>> +                       mboxes = <&apcs_glb 9>;
>> +               };
>> +       };
>> +
>> +       slpi_pas: remoteproc-slpi {
>> +               compatible = "qcom,msm8998-slpi-pas";
>> +
>> +               interrupts-extended = <&intc GIC_SPI 390 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&slpi_smp2p_in 0 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&slpi_smp2p_in 1 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&slpi_smp2p_in 2 
>> IRQ_TYPE_EDGE_RISING>,
>> +                                     <&slpi_smp2p_in 3 
>> IRQ_TYPE_EDGE_RISING>;
>> +               interrupt-names = "wdog", "fatal", "ready",
>> +                                 "handover", "stop-ack";
>> +
>> +               px-supply = <&vreg_lvs2a_1p8>;
>> +
>> +               clocks = <&xo>,
>> +                        <&rpmcc RPM_SMD_AGGR2_NOC_CLK>;
>> +               clock-names = "xo", "aggre2";
>> +
>> +               memory-region = <&slpi_mem>;
>> +
>> +               qcom,smem-states = <&slpi_smp2p_out 0>;
>> +               qcom,smem-state-names = "stop";
>> +
>> +               power-domains = <&rpmpd MSM8998_SSCCX>;
>> +               power-domain-names = "ssc_cx";
>> +
>> +               status = "disabled";
>> +
>> +               glink-edge {
>> +                       interrupts = <GIC_SPI 179 
>> IRQ_TYPE_EDGE_RISING>;
>> +                       label = "dsps";
>> +                       qcom,remote-pid = <3>;
>> +                       mboxes = <&apcs_glb 27>;
>> +               };
>> +       };
>> +
>>         tcsr_mutex: hwlock {
>>                 compatible = "qcom,tcsr-mutex";
>>                 syscon = <&tcsr_mutex_regs 0 0x1000>;
>> @@ -1048,6 +1115,61 @@
>>                         #interrupt-cells = <0x2>;
>>                 };
>> 
>> +               mss_pil: remoteproc@4080000 {
>> +                       compatible = "qcom,msm8998-mss-pil";
>> +                       reg = <0x04080000 0x100>, <0x04180000 0x20>;
>> +                       reg-names = "qdsp6", "rmb";
>> +
>> +                       interrupts-extended =
>> +                               <&intc GIC_SPI 448 
>> IRQ_TYPE_EDGE_RISING>,
>> +                               <&modem_smp2p_in 0 
>> IRQ_TYPE_EDGE_RISING>,
>> +                               <&modem_smp2p_in 1 
>> IRQ_TYPE_EDGE_RISING>,
>> +                               <&modem_smp2p_in 2 
>> IRQ_TYPE_EDGE_RISING>,
>> +                               <&modem_smp2p_in 3 
>> IRQ_TYPE_EDGE_RISING>,
>> +                               <&modem_smp2p_in 7 
>> IRQ_TYPE_EDGE_RISING>;
>> +                       interrupt-names = "wdog", "fatal", "ready",
>> +                                         "handover", "stop-ack",
>> +                                         "shutdown-ack";
>> +
>> +                       clocks = <&xo>,
>> +                                <&gcc GCC_MSS_CFG_AHB_CLK>,
>> +                                <&gcc GCC_BIMC_MSS_Q6_AXI_CLK>,
>> +                                <&gcc GCC_BOOT_ROM_AHB_CLK>,
>> +                                <&gcc GCC_MSS_GPLL0_DIV_CLK_SRC>,
>> +                                <&gcc GCC_MSS_SNOC_AXI_CLK>,
>> +                                <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
>> +                                <&rpmcc RPM_SMD_QDSS_CLK>;
>> +                       clock-names = "xo", "iface", "bus", "mem", 
>> "gpll0_mss",
>> +                                     "snoc_axi", "mnoc_axi", "qdss";
>> +
>> +                       qcom,smem-states = <&modem_smp2p_out 0>;
>> +                       qcom,smem-state-names = "stop";
>> +
>> +                       resets = <&gcc GCC_MSS_RESTART>;
>> +                       reset-names = "mss_restart";
>> +
>> +                       qcom,halt-regs = <&tcsr_mutex_regs 0x23000 
>> 0x25000 0x24000>;
>> +
>> +                       power-domains = <&rpmpd MSM8998_VDDCX>,
>> +                                       <&rpmpd MSM8998_VDDMX>;
>> +                       power-domain-names = "cx", "mx";
>> +
>> +                       mba {
>> +                               memory-region = <&mba_mem>;
>> +                       };
>> +
>> +                       mpss {
>> +                               memory-region = <&mpss_mem>;
>> +                       };
>> +
>> +                       glink-edge {
>> +                               interrupts = <GIC_SPI 452 
>> IRQ_TYPE_EDGE_RISING>;
>> +                               label = "modem";
>> +                               qcom,remote-pid = <1>;
>> +                               mboxes = <&apcs_glb 15>;
>> +                       };
>> +               };
>> +
>>                 stm: stm@6002000 {
>>                         compatible = "arm,coresight-stm", 
>> "arm,primecell";
>>                         reg = <0x06002000 0x1000>,
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 

  reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191118214250.14002-1-sibis@codeaurora.org>
2019-11-18 21:43 ` [PATCH 01/16] remoteproc: q6v5-mss: fixup MSM8998 MSS out of reset sequence Sibi Sankar
2019-11-18 21:54   ` Jeffrey Hugo
2019-11-19 15:25     ` Sibi Sankar
     [not found]     ` <0101016e844504f1-d8bd27a5-c0bf-4b0b-8301-7bd8a890be80-000000@us-west-2.amazonses.com>
2019-11-19 15:43       ` Jeffrey Hugo
2019-11-20 12:01         ` Sibi Sankar
2019-11-18 21:43 ` [PATCH 02/16] remoteproc: q6v5-mss: Streamline the " Sibi Sankar
2019-11-18 21:43 ` [PATCH 03/16] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding for SC7180 Sibi Sankar
2019-11-22 23:12   ` Rob Herring
2019-11-18 21:43 ` [PATCH 04/16] remoteproc: mss: q6v5-mss: Add modem support on SC7180 Sibi Sankar
2019-11-18 21:43 ` [PATCH 05/16] remoteproc: qcom: pas: Disable interrupt on clock enable failure Sibi Sankar
2019-11-18 21:43 ` [PATCH 06/16] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 PAS Sibi Sankar
2019-11-22 23:15   ` Rob Herring
2019-11-18 21:43 ` [PATCH 07/16] remoteproc: qcom: pas: Vote for active/proxy power domains Sibi Sankar
2019-11-18 21:43 ` [PATCH 08/16] dt-bindings: remoteproc: qcom: Add ADSP and SLPI support for MSM8998 SoC Sibi Sankar
2019-12-03 22:01   ` Rob Herring
2019-11-18 21:43 ` [PATCH 09/16] remoteproc: qcom: pas: Add MSM8998 ADSP and SLPI support Sibi Sankar
2019-11-18 21:43 ` [PATCH 10/16] dt-bindings: remoteproc: qcom: SM8150 Add ADSP, CDSP, MPSS " Sibi Sankar
2019-12-03 22:02   ` Rob Herring
2019-11-18 21:43 ` [PATCH 11/16] remoteproc: qcom: pas: Add SM8150 ADSP, CDSP, Modem " Sibi Sankar
2019-11-18 21:44 ` [PATCH 12/16] remoteproc: qcom: pas: Add auto_boot flag Sibi Sankar
2019-11-18 21:44 ` [PATCH 13/16] arm64: dts: qcom: msm8998: Update reserved memory map Sibi Sankar
2019-11-18 22:04   ` Jeffrey Hugo
2019-11-19 12:28     ` sibis
2019-11-18 21:44 ` [PATCH 14/16] arm64: dts: qcom: msm8998: Add ADSP, MPSS and SLPI nodes Sibi Sankar
2019-11-18 22:07   ` Jeffrey Hugo
2019-11-19 12:29     ` sibis [this message]
2019-11-18 21:44 ` [PATCH 15/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI smp2p Sibi Sankar
2019-11-18 21:44 ` [PATCH 16/16] arm64: dts: qcom: sm8150: Add ADSP, CDSP, MPSS and SLPI remoteprocs Sibi Sankar
2019-12-17  0:19   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101016e83a3aae0-2f25d2f3-6014-4992-9b40-d8716962215b-000000@us-west-2.amazonses.com \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jeffrey.l.hugo@gmail.com \
    --cc=jhugo@codeaurora.org \
    --cc=jonathan@marek.ca \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ohad@wizery.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git