From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2493C432C0 for ; Mon, 25 Nov 2019 12:15:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732E120674 for ; Mon, 25 Nov 2019 12:15:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="k33wwE1s"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="JAQUZMQA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbfKYMPA (ORCPT ); Mon, 25 Nov 2019 07:15:00 -0500 Received: from a27-185.smtp-out.us-west-2.amazonses.com ([54.240.27.185]:56476 "EHLO a27-185.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfKYMPA (ORCPT ); Mon, 25 Nov 2019 07:15:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574684099; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date; bh=FYS9WywPAdYEkfH5HwtBByCXzTvOkzfIsREpBKqsp2Q=; b=k33wwE1sDLEH5lvh2dQgQ6AGE9noYYXlWHB4n28pLiGfeUroOxaFidRUYPVFPRcA h9lIpEvpL8I2H5TmJyy8CQ5XWlqgAfK0ktDHHSMoD3fn2mjSq8mRROUmsoKvHSLSIdc uAvxBoZp7DWDApzfrbYCOwrGwL9KbT8GA44I3olM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574684099; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date:Feedback-ID; bh=FYS9WywPAdYEkfH5HwtBByCXzTvOkzfIsREpBKqsp2Q=; b=JAQUZMQA7hAvQZk6uUmWvW6GoN24nuu4KP4Cocmn47L/RPAqE6h9NST0i0alTxDp yXE6SLEmhEPayhFxW11PBHUNmccEbKgxqxJrwzUZOG+Wcts5WFBNYCEawv8XgPiH0Pk 1LAkIY2qWTuDqTaQfWBOGEwQuOhXp5n6BysUTH4A= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D993DC76F45 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wil6210: fix break that is never reached because of zero'ing of a retry counter From: Kalle Valo In-Reply-To: <20191115120953.48137-1-colin.king@canonical.com> References: <20191115120953.48137-1-colin.king@canonical.com> To: Colin King Cc: Maya Erez , "David S . Miller" , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <0101016ea27c8290-6a36151e-699b-46d6-a206-290403315074-000000@us-west-2.amazonses.com> Date: Mon, 25 Nov 2019 12:14:59 +0000 X-SES-Outgoing: 2019.11.25-54.240.27.185 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > There is a check on the retry counter invalid_buf_id_retry that is always > false because invalid_buf_id_retry is initialized to zero on each iteration > of a while-loop. Fix this by initializing the retry counter before the > while-loop starts. > > Addresses-Coverity: ("Logically dead code") > Fixes: b4a967b7d0f5 ("wil6210: reset buff id in status message after completion") > Signed-off-by: Colin Ian King > Reviewed-by: Maya Erez > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5b1413f00b5b wil6210: fix break that is never reached because of zero'ing of a retry counter -- https://patchwork.kernel.org/patch/11246193/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches