From: Kalle Valo <kvalo@codeaurora.org>
To: "Rakesh Pillai" <pillair@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Use bdf calibration variant for snoc targets
Date: Mon, 7 Sep 2020 16:17:57 +0000 [thread overview]
Message-ID: <01010174695c181a-6f8e9efc-bbc9-45ff-8d54-62db5e0163f6-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <0101017459fdd62b-791355e4-ea88-4142-96a7-06849bcd7b09-000000@us-west-2.amazonses.com> (Rakesh Pillai's message of "Fri, 4 Sep 2020 16:40:41 +0000")
"Rakesh Pillai" <pillair@codeaurora.org> writes:
>> > --- a/drivers/net/wireless/ath/ath10k/qmi.c
>> > +++ b/drivers/net/wireless/ath/ath10k/qmi.c
>> > @@ -576,6 +576,8 @@ static int ath10k_qmi_cap_send_sync_msg(struct
>> ath10k_qmi *qmi)
>> > if (resp->chip_info_valid) {
>> > qmi->chip_info.chip_id = resp->chip_info.chip_id;
>> > qmi->chip_info.chip_family = resp->chip_info.chip_family;
>> > + } else {
>> > + qmi->chip_info.chip_id = 0xFF;
>> > }
>>
>> So you hard code chip_id to 0xff if it's not valid. Is it 100%
>> guaranteed that there never will be a chip id with 0xff?
>
> 0x0 and 0xff are invalid chip id and are are not used.
> If the chip_id read fails, we fallback to the default board data.
> 0xff is used to go to the default board data (Also this is in alignment with
> the current implementation of board_id)
>
> Does that make sense ?
I'm a bit hesitant, over the years I have seen cases so many cases where
"foo is not used anywhere" and later that foo is actually used
somewhere. 0xff means that there's only 254 different values, but I
guess there are not that many chip ids? So a chip id is very different
from a board id, right?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-09-07 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 17:53 [PATCH] ath10k: Use bdf calibration variant for snoc targets Rakesh Pillai
2020-09-02 8:47 ` Kalle Valo
2020-09-04 16:40 ` Rakesh Pillai
[not found] ` <0101017459fdd62b-791355e4-ea88-4142-96a7-06849bcd7b09-000000@us-west-2.amazonses.com>
2020-09-07 16:17 ` Kalle Valo [this message]
[not found] ` <87k0x51rz3.fsf@codeaurora.org>
2020-09-10 13:11 ` Rakesh Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01010174695c181a-6f8e9efc-bbc9-45ff-8d54-62db5e0163f6-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).