From: Alexandre Torgue <alexandre.torgue@st.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Alexandru Ardelean <alexaundru.ardelean@analog.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: net: adi: Fix yaml verification issue
Date: Mon, 7 Oct 2019 16:07:17 +0200 [thread overview]
Message-ID: <01041a6b-7c70-bebd-d04b-9e47ce238e5e@st.com> (raw)
In-Reply-To: <CAL_JsqKFUTwjJefQvQE5aFmeJButYSLKm0RSpCHjSL=7pQHtxQ@mail.gmail.com>
Hi Rob
On 10/7/19 3:56 PM, Rob Herring wrote:
> On Mon, Oct 7, 2019 at 5:26 AM Alexandre Torgue <alexandre.torgue@st.com> wrote:
>>
>> This commit fixes an issue seen during yaml check ("make dt_binding_check").
>> Each enum were not declared as uint32.
>>
>> "Documentation/devicetree/bindings/net/adi,adin.yaml:
>> properties:adi,rx-internal-delay-ps:
>> ..., 'enum': [1600, 1800, 2000, 2200, 2400], 'default': 2000}
>> is not valid under any of the given schemas"
>
> You need to update dtschema. I fixed this in the meta-schema last
> week. Any property with a standard property unit suffix has a defined
> type already, so we don't need to define it again here.
>
> I also added '-bits' to standard units.
Nice, I'm going to update my tools.
thanks
Alex
>
> Rob
>
next prev parent reply other threads:[~2019-10-07 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:25 [PATCH 0/3] Fixes for dt-bindings verification Alexandre Torgue
2019-10-07 10:25 ` [PATCH 1/3] dt-bindings: media: Fix id path for sun4i-a10-csi Alexandre Torgue
2019-10-07 11:00 ` Maxime Ripard
2019-10-07 14:08 ` Alexandre Torgue
2019-10-07 10:25 ` [PATCH 2/3] dt-bindings: net: adi: Fix yaml verification issue Alexandre Torgue
2019-10-07 13:56 ` Rob Herring
2019-10-07 14:07 ` Alexandre Torgue [this message]
2019-10-07 10:25 ` [PATCH 3/3] dt-bindings: regulator: Fix yaml verification for fixed-regulator schema Alexandre Torgue
2019-10-07 13:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01041a6b-7c70-bebd-d04b-9e47ce238e5e@st.com \
--to=alexandre.torgue@st.com \
--cc=alexaundru.ardelean@analog.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).