From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4D8C43460 for ; Fri, 23 Apr 2021 08:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B27E611C2 for ; Fri, 23 Apr 2021 08:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241372AbhDWIFL convert rfc822-to-8bit (ORCPT ); Fri, 23 Apr 2021 04:05:11 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:56637 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241340AbhDWIFJ (ORCPT ); Fri, 23 Apr 2021 04:05:09 -0400 X-Greylist: delayed 584 seconds by postgrey-1.27 at vger.kernel.org; Fri, 23 Apr 2021 04:05:08 EDT X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="40413722" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 23 Apr 2021 15:54:46 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(9037:0:AUTH_RELAY) (envelope-from ); Fri, 23 Apr 2021 15:54:44 +0800 (CST) Received: from 192.168.55.71 by webmail.emc.com.tw with Mail2000 ESMTPA Server V7.00(2473:0:AUTH_LOGIN) (envelope-from ); Fri, 23 Apr 2021 15:54:41 +0800 (CST) From: "Johnny.Chuang" To: "'Doug Anderson'" , "'Johnny Chuang'" Cc: "'Dmitry Torokhov'" , "'Benjamin Tissoires'" , "'Peter Hutterer'" , "'LKML'" , "'open list:HID CORE LAYER'" , "'Harry Cutts'" , "'James Chen'" , "'Jennifer Tsai'" , "'Paul Liang'" , "'Jeff Chuang'" , "'Jingle'" References: <1618276850-27178-1-git-send-email-johnny.chuang.emc@gmail.com> In-Reply-To: Subject: RE: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset Date: Fri, 23 Apr 2021 15:54:42 +0800 Message-ID: <011101d73815$eb73ea30$c25bbe90$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQG7a3HnjRYiIwf6YyXjsXt955W0TQGCv5oKqu063NA= Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDUwMTBcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0yOGNiZDgyZi1hNDA5LTExZWItODY2Mi03YzVjZjg3NDk0NzhcYW1lLXRlc3RcMjhjYmQ4MzEtYTQwOS0xMWViLTg2NjItN2M1Y2Y4NzQ5NDc4Ym9keS50eHQiIHN6PSIxMzkyIiB0PSIxMzI2MzYzODA4MjE0NjA4NTciIGg9ImtuU2s2SVJmTTdBeXZ3ZEt4UDBWNkVML1ZtQT0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi, > > On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang > wrote: > > > > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset"). > > Note that the "Fixes" tag actually belongs down at the end. It also shouldn't > have a "." at the end. Presumably the maintainer can adjust this when landing? > Hi Dmitry, Could you help to review this patch and give an advice? > > > For ELAN touchscreen, we found our boot code of IC was not flexible > > enough to receive and handle this command. > > Once the FW main code of our controller is crashed for some reason, > > the controller could not be enumerated successfully to be recognized > > by the system host. therefore, it lost touch functionality. > > > > Add quirk for skip send power-on command after reset. > > It will impact to ELAN touchscreen and touchpad on HID over I2C projects. > > > > Signed-off-by: Johnny Chuang > > This patch looks fine to me, thus: > > Reviewed-by: Douglas Anderson > > I can confirm that after applying this patch I can recovery my borked > touchscreen (which got borked by a failed firmware update ages ago): > > Tested-by: Douglas Anderson