From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899DBC43214 for ; Fri, 27 Aug 2021 04:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ED5160EE5 for ; Fri, 27 Aug 2021 04:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233822AbhH0EQb (ORCPT ); Fri, 27 Aug 2021 00:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhH0EQ3 (ORCPT ); Fri, 27 Aug 2021 00:16:29 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B649C061757; Thu, 26 Aug 2021 21:15:41 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id q21so9112824ljj.6; Thu, 26 Aug 2021 21:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SyhHgV5tmGCX9EPESfwHvVUgx4qCN8VC/mRNtowNnh0=; b=pIrUozoO0pV0T3BaVPB2WheUxq08WOaRZJQ53dtVSvbYm0X9gwbq1E1Z+WKCp/oGOv U/AwQNtbGgmPJPjt5EVt5LunpTMAnX8t41nM7Bl8x91YtiuZiPRBglcTDUG6LO+PHr5z s61MS5czakRQ3pwVFz8W9r9xHRcgT05YVixj4Z7iHaVWkbBZFM+cdBbfbTu9gJYUnc43 GcLGxhVu556rPFQ8YwTYgsBlMjGusIrVKVgxSU7USTLFGOeHR0J06BPhE+qnzzM5iAKH EVCVJJDxkKjQVyOeXUP2OWTi0be/dxuh3txGmrKtBKFn1vruEKXpwNVviqKfJni2TwuK emmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SyhHgV5tmGCX9EPESfwHvVUgx4qCN8VC/mRNtowNnh0=; b=V/WlBr3Dh09rFuRx1Yl19q7Bj53DXjqV6fntpqce1x+WittJiPraHmpRrdCBp3tcKm tbUnsI602PbaJe5kYQz9XapuIrVb7BrUAH7LO7FTqZrzbF4TeFzlOygzd1JfM95VaLZN snmVyY0Q/fSlC4XzaLdlPstQeUeN4UgD0c/R/1rHiflvOp8N+KIwmPExRMYEkMy1WhdC sdhPSOf6sh7mBSWNTPwJTHXkfqayRTzgNeoVU/CLNJTwoKl8eFNreldyUFiqUi9zE04+ njD4GPtdVeZx+M+u7gxPbKqihSFG8UTu7gmmOJ5w95lTgsfpD3tGvyIqTO+DdWHaCVN4 cHpg== X-Gm-Message-State: AOAM532BGqwYNXVKt93Y3PM9hheUv707WK17zb3mh16Z1NsMJtKPoHVm 4F8c+HBb5sSTbgptDHahLwKwDsJnRc4= X-Google-Smtp-Source: ABdhPJzMmDjs3tgVeVB3w/NSRqThcAnkcJFyzHyj0wG0hDpRHoJzdUGE1zuNyE5jqInZtxz/cISkTw== X-Received: by 2002:a2e:8185:: with SMTP id e5mr6054691ljg.31.1630037739601; Thu, 26 Aug 2021 21:15:39 -0700 (PDT) Received: from [192.168.2.145] (94-29-17-251.dynamic.spd-mgts.ru. [94.29.17.251]) by smtp.googlemail.com with ESMTPSA id l26sm477488lfh.247.2021.08.26.21.15.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 21:15:39 -0700 (PDT) Subject: Re: [PATCH v9 5/8] soc/tegra: pmc: Implement get_performance_state() callback To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20210827013415.24027-1-digetx@gmail.com> <20210827013415.24027-6-digetx@gmail.com> <20210827030557.aymjkky7athjxpow@vireshk-i7> <9c2287ca-4c51-d782-a0a5-4b1227c2e9db@gmail.com> <7aca6da3-89a7-a4a6-c720-8be4a105a696@gmail.com> <20210827040239.roal5jpndamzotle@vireshk-i7> <4a945d40-b30a-8a30-bdf8-4e17ad26cea7@gmail.com> <20210827041303.5rz6xcyc2bo75tbr@vireshk-i7> From: Dmitry Osipenko Message-ID: <01117523-5793-e3ff-9d50-24f964e4e745@gmail.com> Date: Fri, 27 Aug 2021 07:15:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210827041303.5rz6xcyc2bo75tbr@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.08.2021 07:13, Viresh Kumar пишет: > On 27-08-21, 07:08, Dmitry Osipenko wrote: >> 27.08.2021 07:02, Viresh Kumar пишет: >>> On 27-08-21, 06:47, Dmitry Osipenko wrote: >>>> Actually, it doesn't work. >>>> >>>> The devm_tegra_core_dev_init_opp_table() needs to set clk to support older device-tree and now OPP table already has clk being set. >>>> >>>> WARNING: CPU: 2 PID: 92 at drivers/opp/core.c:2146 dev_pm_opp_set_clkname+0x97/0xb8 >>>> Modules linked in: >>>> CPU: 2 PID: 92 Comm: kworker/u8:1 Tainted: G W 5.14.0-rc7-next-20210826-00181-g6389463cbb0a #9318 >>>> Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) >>>> Workqueue: events_unbound deferred_probe_work_func >>>> [] (unwind_backtrace) from [] (show_stack+0x11/0x14) >>>> [] (show_stack) from [] (dump_stack_lvl+0x2b/0x34) >>>> [] (dump_stack_lvl) from [] (__warn+0xbb/0x100) >>>> [] (__warn) from [] (warn_slowpath_fmt+0x4b/0x80) >>>> [] (warn_slowpath_fmt) from [] (dev_pm_opp_set_clkname+0x97/0xb8) >>>> [] (dev_pm_opp_set_clkname) from [] (devm_pm_opp_set_clkname+0xf/0x64) >>>> [] (devm_pm_opp_set_clkname) from [] (devm_tegra_core_dev_init_opp_table+0x23/0x144) >>> >>> Why are you calling this anymore ? >> >> Older device-trees don't have OPPs, meanwhile drivers will use >> dev_pm_opp_set_rate() and it requires OPP table to be set up using >> devm_pm_opp_set_clkname(). >> >> The devm_tegra_core_dev_init_opp_table() is a common helper that sets up >> OPP table for Tegra drivers and it sets the clk. > > Ahh, I see. that's okay then. Just add a comment over it to specify the same. > Doing devm_pm_opp_set_clkname(dev, NULL) is special and looks suspicious > otherwise. I'll add comment, thanks.