From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553AbbCFDil (ORCPT ); Thu, 5 Mar 2015 22:38:41 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:40162 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340AbbCFDii (ORCPT ); Thu, 5 Mar 2015 22:38:38 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-02-54f92134e507 From: Chao Yu To: "'Changman Lee'" , linux-f2fs-devel@lists.sourceforge.net Cc: "'Jaegeuk Kim'" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <1425029893-24702-1-git-send-email-wanpeng.li@linux.intel.com> <20150303014022.GD6541@lcm-devel.org> In-reply-to: <20150303014022.GD6541@lcm-devel.org> Subject: RE: [PATCH v2] f2fs: fix max orphan inodes calculation Date: Fri, 06 Mar 2015 11:37:28 +0800 Message-id: <012301d057bf$029602e0$07c208a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQHmSlLQcqTjyjRrXhusXuwW79ud/gJZCltWnNAZL9A= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t9jQV0TxZ8hBlfe2Vhc29fIZPFk/Sxm i0uL3C327D3JYnF51xw2B1aPTas62Tx2L/jM5NG3ZRWjx+dNcgEsUVw2Kak5mWWpRfp2CVwZ fx9cZil4KVpx7scjtgbGuYJdjJwcEgImEkufvWOCsMUkLtxbz9bFyMUhJDCdUeL4niesEM4P RonrJ/sYQarYBFQklnf8B+sQEQiROPviDBuIzSyQKnFw4U8wW0igSOLrlqXMIDangJHE80O7 2UFsYQF7iXdvz4HFWQRUJVac/AU2h1fAUmLK1acsELagxI/J91ggZmpJrN95nAnClpfYvOYt M8SlChI7zr5mhLjBSuL7nK2MEDXiEhuP3GKZwCg0C8moWUhGzUIyahaSlgWMLKsYRVMLkguK k9JzjfSKE3OLS/PS9ZLzczcxguPhmfQOxlUNFocYBTgYlXh4NQR/hgixJpYVV+YeYpTgYFYS 4d3ECxTiTUmsrEotyo8vKs1JLT7EKM3BoiTOq2TfFiIkkJ5YkpqdmlqQWgSTZeLglGpgLMw8 s1Dty/MTVic0pk8P7Pn1+9j9Fol7F0O9HjxrZlnv2XJm6ZxH8s+lNyp+u2vD1OcrcItF6Uiw qC6fQecsDu5NqyVjrnaKeb+YxPNH2enXpJy9bX/UdiQuXXGnZ3XM/H6+nwHsUs/O6za+snfn WqFg2pRpd2pugmPook33A6uvP9Nt7pZ5psRSnJFoqMVcVJwIAPduKoaDAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Changman, > -----Original Message----- > From: Changman Lee [mailto:cm224.lee@samsung.com] > Sent: Tuesday, March 03, 2015 9:40 AM > To: linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim; Chao Yu; linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] f2fs: fix max orphan inodes calculation > > On Fri, Feb 27, 2015 at 05:38:13PM +0800, Wanpeng Li wrote: > > cp_payload is introduced for sit bitmap to support large volume, and it is > > just after the block of f2fs_checkpoint + nat bitmap, so the first segment > > should include F2FS_CP_PACKS + NR_CURSEG_TYPE + cp_payload + orphan blocks. > > However, current max orphan inodes calculation don't consider cp_payload, > > this patch fix it by reducing the number of cp_payload from total blocks of > > the first segment when calculate max orphan inodes. > > > > Signed-off-by: Wanpeng Li > > --- > > v1 -> v2: > > * adjust comments above the codes > > * fix coding style issue > > > > fs/f2fs/checkpoint.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > index db82e09..a914e99 100644 > > --- a/fs/f2fs/checkpoint.c > > +++ b/fs/f2fs/checkpoint.c > > @@ -1103,13 +1103,15 @@ void init_ino_entry_info(struct f2fs_sb_info *sbi) > > } > > > > /* > > - * considering 512 blocks in a segment 8 blocks are needed for cp > > - * and log segment summaries. Remaining blocks are used to keep > > - * orphan entries with the limitation one reserved segment > > - * for cp pack we can have max 1020*504 orphan entries > > + * considering 512 blocks in a segment 8+cp_payload blocks are > > + * needed for cp and log segment summaries. Remaining blocks are > > + * used to keep orphan entries with the limitation one reserved > > + * segment for cp pack we can have max 1020*(504-cp_payload) > > + * orphan entries > > */ > > Hi all, > > I think below code give us information enough so it doesn't need to > describe above comments. And someone could get confused by 1020 constants. > How do you think about removing comments. I agree with you. There are nothing special need to be pay attention for the below statement, all meaning of statement could be easily readed as each macro in statement can indicate meaning of itself clearly. So could you send another patch to remove it? Thanks, > > Regards, > Changman > > > sbi->max_orphans = (sbi->blocks_per_seg - F2FS_CP_PACKS - > > - NR_CURSEG_TYPE) * F2FS_ORPHANS_PER_BLOCK; > > + NR_CURSEG_TYPE - __cp_payload(sbi)) * > > + F2FS_ORPHANS_PER_BLOCK; > > } > > > > int __init create_checkpoint_caches(void) > > -- > > 1.9.1