From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, Jiri Slaby <jslaby@suse.cz>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-serial@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for 5.6 v2] tty: serial: tegra: Handle RX transfer in PIO mode if DMA wasn't started
Date: Wed, 19 Feb 2020 14:38:12 +0000 [thread overview]
Message-ID: <01397ba1-a738-257a-adb1-84cdcba68a57@nvidia.com> (raw)
In-Reply-To: <4d9a2352-6daa-4dcc-376b-175b1398ff6a@gmail.com>
On 19/02/2020 12:25, Dmitry Osipenko wrote:
> 17.02.2020 10:37, Jiri Slaby пишет:
>> On 09. 02. 20, 17:44, Dmitry Osipenko wrote:
>>> It is possible to get an instant RX timeout or end-of-transfer interrupt
>>> before RX DMA was started, if transaction is less than 16 bytes. Transfer
>>> should be handled in PIO mode in this case because DMA can't handle it.
>>> This patch brings back the original behaviour of the driver that was
>>> changed by accident by a previous commit, it fixes occasional Bluetooth HW
>>> initialization failures which I started to notice recently.
>>>
>>> Fixes: d5e3fadb7012 ("tty: serial: tegra: Activate RX DMA transfer by request")
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
>>>
>>> Changelog:
>>>
>>> v2: - Corrected commit's title by adding the accidentally missed "tegra: "
>>> to the prefix.
>>>
>>> drivers/tty/serial/serial-tegra.c | 35 ++++++++++++++-----------------
>>> 1 file changed, 16 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
>>> index 33034b852a51..8de8bac9c6c7 100644
>>> --- a/drivers/tty/serial/serial-tegra.c
>>> +++ b/drivers/tty/serial/serial-tegra.c
>>> @@ -692,11 +692,22 @@ static void tegra_uart_copy_rx_to_tty(struct tegra_uart_port *tup,
>>> count, DMA_TO_DEVICE);
>>> }
>>>
>>> +static void do_handle_rx_pio(struct tegra_uart_port *tup)
>>> +{
>>> + struct tty_struct *tty = tty_port_tty_get(&tup->uport.state->port);
>>> + struct tty_port *port = &tup->uport.state->port;
>>> +
>>> + tegra_uart_handle_rx_pio(tup, port);
>>> + if (tty) {
>>
>> What's the tty good for here, actually?
>>
>>> + tty_flip_buffer_push(port);
>>> + tty_kref_put(tty);
>>> + }
>>> +}
>
> I'm not really a TTY expert..
>
> Jon, maybe you have any clue whether TTY could disappear while port is
> opened?
Nothing specific that I am aware of. The function tty_kref_get() appears
to check that the tty pointer is valid and so it would seem logical to
check here as well. But happy to be corrected :-)
Jon
--
nvpublic
next prev parent reply other threads:[~2020-02-19 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 16:44 [PATCH for 5.6 v2] tty: serial: tegra: Handle RX transfer in PIO mode if DMA wasn't started Dmitry Osipenko
2020-02-17 7:37 ` Jiri Slaby
2020-02-19 12:25 ` Dmitry Osipenko
2020-02-19 14:38 ` Jon Hunter [this message]
2020-02-21 19:10 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01397ba1-a738-257a-adb1-84cdcba68a57@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).