From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbdKKSJb (ORCPT ); Sat, 11 Nov 2017 13:09:31 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:52235 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbdKKSJ3 (ORCPT ); Sat, 11 Nov 2017 13:09:29 -0500 X-Google-Smtp-Source: AGs4zMZJz4DckCSA7p/IILHxicyaiF0g37laTIJ3GgvB9dWPbhmZ2HzcR/BWJUxIxqZRcbDG0d+Q1A== From: Arvind Yadav To: jassisinghbrar@gmail.com, s-anna@ti.com Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH] mailbox/omap: unregister mbox class Date: Sat, 11 Nov 2017 23:39:18 +0530 Message-Id: <014a4c5cd6008a42621d45f34d57b9e1a72d3c76.1510423634.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_driver_register() can fail here and we must unregister mbox class. Signed-off-by: Arvind Yadav --- drivers/mailbox/omap-mailbox.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c index c5e8b9c..2517038 100644 --- a/drivers/mailbox/omap-mailbox.c +++ b/drivers/mailbox/omap-mailbox.c @@ -906,7 +906,11 @@ static int __init omap_mbox_init(void) mbox_kfifo_size = max_t(unsigned int, mbox_kfifo_size, sizeof(mbox_msg_t)); - return platform_driver_register(&omap_mbox_driver); + err = platform_driver_register(&omap_mbox_driver); + if (err) + class_unregister(&omap_mbox_class); + + return err; } subsys_initcall(omap_mbox_init); -- 2.7.4