From: Matthias Brugger <matthias.bgg@gmail.com>
To: xinlei.lee@mediatek.com, chunkuang.hu@kernel.org,
p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jitao.shi@mediatek.com, shuijing.li@mediatek.com
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
Date: Thu, 13 Apr 2023 11:09:07 +0200 [thread overview]
Message-ID: <015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com> (raw)
In-Reply-To: <1681366162-4949-4-git-send-email-xinlei.lee@mediatek.com>
On 13/04/2023 08:09, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> For mt8188, add dsi cmdq reg control to send long packets to panel initialization.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 500a3054282d..cbfe5df4647c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -86,6 +86,7 @@
>
> #define DSI_CMDQ_SIZE 0x60
> #define CMDQ_SIZE 0x3f
> +#define CMDQ_SIZE_SEL BIT(15)
>
> #define DSI_HSTX_CKL_WC 0x64
>
> @@ -178,6 +179,7 @@ struct mtk_dsi_driver_data {
> const u32 reg_cmdq_off;
> bool has_shadow_ctl;
> bool has_size_ctl;
> + bool cmdq_long_packet_ctl;
> };
>
> struct mtk_dsi {
> @@ -965,6 +967,11 @@ static u32 mtk_dsi_recv_cnt(u8 type, u8 *read_data)
> return 0;
> }
>
> +static void mtk_dsi_cmd_packet_ctl(struct mtk_dsi *dsi)
> +{
> + mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
> +}
> +
> static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg)
> {
> const char *tx_buf = msg->tx_buf;
> @@ -996,6 +1003,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg)
>
> mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val);
> mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size);
> + if (dsi->driver_data->cmdq_long_packet_ctl)
> + mtk_dsi_cmd_packet_ctl(dsi);
Why don't you put the onliner
mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
directly here. Please help me understand why adding another indirection is
usefull here.
Best regards,
Matthias
> }
>
> static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,
> @@ -1200,18 +1209,21 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = {
> .reg_cmdq_off = 0x200,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = true,
> };
>
> static const struct of_device_id mtk_dsi_of_match[] = {
next prev parent reply other threads:[~2023-04-13 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 6:09 [PATCH 0/3] Add mt8188 compatiable for DSI cmd packet control xinlei.lee
2023-04-13 6:09 ` [PATCH 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 xinlei.lee
2023-04-13 7:55 ` Krzysztof Kozlowski
2023-04-13 9:02 ` Matthias Brugger
2023-06-12 15:19 ` Chun-Kuang Hu
2023-04-13 6:09 ` [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c xinlei.lee
2023-04-13 9:02 ` Matthias Brugger
2023-06-12 15:18 ` Chun-Kuang Hu
2023-04-13 6:09 ` [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code xinlei.lee
2023-04-13 7:27 ` Rex-BC Chen (陳柏辰)
2023-06-16 6:24 ` Shuijing Li (李水静)
2023-04-13 9:09 ` Matthias Brugger [this message]
2023-06-16 6:50 ` Shuijing Li (李水静)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shuijing.li@mediatek.com \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).