From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baruch Siach <baruch@tkos.co.il>,
linux-i2c@vger.kernel.org
Subject: Re: linux-next: Tree for Jan 18 (i2c-designware-platdrv.c)
Date: Mon, 21 Jan 2019 15:36:21 +0200 [thread overview]
Message-ID: <018b454e-ecd8-0ebe-40cc-ab64d3deea00@linux.intel.com> (raw)
In-Reply-To: <590dd86f-93ce-16c3-932e-c5ce53035ab2@infradead.org>
Hi
On 1/18/19 6:27 PM, Randy Dunlap wrote:
> On 1/17/19 8:24 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20190117:
>>
>
> on i386 or x86_64:
>
> ld: drivers/i2c/busses/i2c-designware-platdrv.o: in function `dw_i2c_plat_resume':
> i2c-designware-platdrv.c:(.text+0x4b): undefined reference to `i2c_dw_prepare_clk'
> ld: drivers/i2c/busses/i2c-designware-platdrv.o: in function `dw_i2c_plat_suspend':
> i2c-designware-platdrv.c:(.text+0x95): undefined reference to `i2c_dw_prepare_clk'
> ld: drivers/i2c/busses/i2c-designware-platdrv.o: in function `dw_i2c_plat_probe':
> i2c-designware-platdrv.c:(.text+0x63f): undefined reference to `i2c_dw_prepare_clk'
> ld: i2c-designware-platdrv.c:(.text+0x686): undefined reference to `i2c_dw_read_comp_param'
> ld: i2c-designware-platdrv.c:(.text+0x7b7): undefined reference to `i2c_dw_probe_slave'
> ld: i2c-designware-platdrv.c:(.text+0x7c1): undefined reference to `i2c_dw_probe'
>
>
> probably related to:
>
> WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
> Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y])
> Selected by [y]:
> - MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
>
Thanks, this is due CONFIG_MFD_TPS68470 which selects the
I2C_DESIGNWARE_PLATFORM but not the dependencies. There are two others
in drivers/mfd/Kconfig. I'll send a patch changing them to depend on
I2C_DESIGNWARE_PLATFORM=y.
--
Jarkko
prev parent reply other threads:[~2019-01-21 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 4:24 linux-next: Tree for Jan 18 Stephen Rothwell
2019-01-18 16:27 ` linux-next: Tree for Jan 18 (i2c-designware-platdrv.c) Randy Dunlap
2019-01-21 13:36 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018b454e-ecd8-0ebe-40cc-ab64d3deea00@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=baruch@tkos.co.il \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).