From: Kassey Li <quic_yingangl@quicinc.com>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
kernel test robot <lkp@intel.com>, <akpm@linux-foundation.org>
Cc: <kbuild-all@lists.01.org>, <minchan@kernel.org>, <vbabka@suse.cz>,
<iamjoonsoo.kim@lge.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>
Subject: Re: [PATCH v6] mm/page_owner.c: add llseek for page_owner
Date: Mon, 15 Aug 2022 14:31:29 +0800 [thread overview]
Message-ID: <0190ae72-4f93-0b7e-9a73-7656dfed29f8@quicinc.com> (raw)
In-Reply-To: <33d41fbd-a2ed-d2ef-4395-e18aac7c0d28@kernel.org>
On 8/11/2022 5:40 PM, Vlastimil Babka (SUSE) wrote:
> On 8/11/22 05:02, Kassey Li wrote:
>> hi, Vlastimil:
>>
>>
>> On 8/10/2022 5:02 PM, kernel test robot wrote:
>>> Hi Kassey,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on v5.19]
>>> [also build test ERROR on next-20220810]
>>> [cannot apply to akpm-mm/mm-everything linus/master]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>>
>>> url:
>>> https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417
>>> base: 3d7cb6b04c3f3115719235cc6866b10326de34cd
>>> config: parisc-buildonly-randconfig-r004-20220810
>>> (https://download.01.org/0day-ci/archive/20220810/202208101628.o6qUzx50-lkp@intel.com/config)
>>> compiler: hppa-linux-gcc (GCC) 12.1.0
>>> reproduce (this is a W=1 build):
>>> wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> #
>>> https://github.com/intel-lab-lkp/linux/commit/d2decd69a8d5756c1706092c805a4c8af14df471
>>> git remote add linux-review https://github.com/intel-lab-lkp/linux
>>> git fetch --no-tags linux-review
>>> Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417
>>> git checkout d2decd69a8d5756c1706092c805a4c8af14df471
>>> # save the config file
>>> mkdir build_dir && cp config build_dir/.config
>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross
>>> W=1 O=build_dir ARCH=parisc SHELL=/bin/bash
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> In file included from mm/page_owner.c:16:
>>>>> mm/../fs/proc/internal.h:51:9: error: unknown type name 'proc_write_t'
>>> 51 | proc_write_t write;
>>> | ^~~~~~~~~~~~
>>
>> # CONFIG_PROC_FS is not set in some arch, so we can not directly include the
>> header file.
>> +#include "../fs/proc/internal.h"
>>
>> how about add an extern ? or do you have other suggest ?
>
> Hi, I replied to v5 after the bot reports:
>
> Sorry, my suggestion (to reuse mem_lseek() from proc) was wrong as the
> kernel test bot just showed us. mem_lseek() may be unavailable without
> CONFIG_PROC_FS.
> The easiest way is to add a page_owner specific lseek function back as in
> the early version, but make it correct for SEEK_CUR. Thanks.
OK, got this point.
>
prev parent reply other threads:[~2022-08-15 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 1:32 [PATCH v6] mm/page_owner.c: add llseek for page_owner Kassey Li
2022-08-10 9:02 ` kernel test robot
2022-08-11 3:02 ` Kassey Li
2022-08-11 9:40 ` Vlastimil Babka (SUSE)
2022-08-15 6:31 ` Kassey Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0190ae72-4f93-0b7e-9a73-7656dfed29f8@quicinc.com \
--to=quic_yingangl@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=minchan@kernel.org \
--cc=vbabka@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).