From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Mike Kravetz'" <mike.kravetz@oracle.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: "'Andrea Arcangeli'" <aarcange@redhat.com>,
"'Hugh Dickins'" <hughd@google.com>,
"'Dave Hansen'" <dave.hansen@linux.intel.com>,
"'Kirill A. Shutemov'" <kirill.shutemov@linux.intel.com>,
"'Naoya Horiguchi'" <n-horiguchi@ah.jp.nec.com>,
"'Michal Hocko'" <mhocko@suse.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY
Date: Tue, 07 Jun 2016 14:27:48 +0800 [thread overview]
Message-ID: <01ad01d1c085$b61fdd60$225f9820$@alibaba-inc.com> (raw)
In-Reply-To: <1465235131-6112-4-git-send-email-mike.kravetz@oracle.com>
> @@ -182,6 +354,13 @@ retry:
> goto out_unlock;
>
> /*
> + * If this is a HUGETLB vma, pass off to appropriate routine
> + */
> + if (dst_vma->vm_flags & VM_HUGETLB)
Use is_vm_hugetlb_page()?
And in cases in subsequent patches?
Hillf
> + return __mcopy_atomic_hugetlb(dst_mm, dst_vma, dst_start,
> + src_start, len, false);
> +
> + /*
> * Be strict and only allow __mcopy_atomic on userfaultfd
> * registered ranges to prevent userland errors going
> * unnoticed. As far as the VM consistency is concerned, it
> --
> 2.4.11
next prev parent reply other threads:[~2016-06-07 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:45 [RFC PATCH 0/6] hugetlb support for userfaultfd Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 1/6] mm/memory: add copy_huge_page_from_user for hugetlb userfaultfd support Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 2/6] mm/hugetlb: add hugetlb_mcopy_atomic_pte for " Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY Mike Kravetz
2016-06-07 6:27 ` Hillf Danton [this message]
2016-06-07 16:35 ` Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 4/6] mm/hugetlb: add userfaultfd hugetlb hook Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 5/6] fs/userfaultfd: allow registration of ranges containing huge pages Mike Kravetz
2016-06-06 17:45 ` [RFC PATCH 6/6] selftests/userfaultfd: add userfaultfd_hugetlb test Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01ad01d1c085$b61fdd60$225f9820$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).