From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Joel Stanley" <joel@jms.id.au>
Cc: netdev <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>
Subject: Re: [PATCH 2/3] dt-bindings: net: ftgmac100: Describe clock properties
Date: Wed, 09 Oct 2019 10:49:45 +1030 [thread overview]
Message-ID: <01c7cafe-8b41-4099-af29-3593e27a1d20@www.fastmail.com> (raw)
In-Reply-To: <CACPK8XcWLCGupAF1EX1LB6A=mQY0s9kjgagr3EKEKJhnbt+j0g@mail.gmail.com>
On Tue, 8 Oct 2019, at 23:12, Joel Stanley wrote:
> On Tue, 8 Oct 2019 at 11:50, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> > Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is
> > in use.
> >
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> > Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > index 04cc0191b7dd..c443b0b84be5 100644
> > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
> > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > @@ -24,6 +24,12 @@ Optional properties:
> > - no-hw-checksum: Used to disable HW checksum support. Here for backward
> > compatibility as the driver now should have correct defaults based on
> > the SoC.
> > +- clocks: In accordance with the generic clock bindings. Must describe the MAC
> > + IP clock, and optionally an RMII RCLK gate for the AST2600.
>
> or AST2500.
>
> With that fixed you can add my ack.
I'll do a v2 and fix the comments in the driver patch as well.
Cheers,
Andrew
next prev parent reply other threads:[~2019-10-09 0:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 11:51 [PATCH 0/3] net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs Andrew Jeffery
2019-10-08 11:51 ` [PATCH 1/3] dt-bindings: net: ftgmac100: Document AST2600 compatible Andrew Jeffery
2019-10-08 12:40 ` Joel Stanley
2019-10-09 4:38 ` Benjamin Herrenschmidt
2019-10-09 4:49 ` Andrew Jeffery
2019-10-09 4:55 ` Andrew Jeffery
2019-10-10 0:10 ` Benjamin Herrenschmidt
2019-10-08 11:51 ` [PATCH 2/3] dt-bindings: net: ftgmac100: Describe clock properties Andrew Jeffery
2019-10-08 12:42 ` Joel Stanley
2019-10-09 0:19 ` Andrew Jeffery [this message]
2019-10-08 11:51 ` [PATCH 3/3] net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs Andrew Jeffery
2019-10-08 12:44 ` Joel Stanley
2019-10-09 0:38 ` [PATCH 0/3] " Florian Fainelli
2019-10-09 1:11 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c7cafe-8b41-4099-af29-3593e27a1d20@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).