From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932761AbcH2LJm (ORCPT ); Mon, 29 Aug 2016 07:09:42 -0400 Received: from mout.web.de ([212.227.15.3]:59569 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756636AbcH2LJh (ORCPT ); Mon, 29 Aug 2016 07:09:37 -0400 Subject: [PATCH 2/5] powerpc-MSI: Use kmalloc_array() in ppc4xx_setup_msi_irqs() To: linuxppc-dev@lists.ozlabs.org, Adam Buchbinder , Andrew Donnellan , Benjamin Herrenschmidt , Marc Zyngier , Michael Ellerman , Paul Mackerras , Scott Wood , Sudeep Holla , Thomas Gleixner References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <01cf542d-c65e-ff66-6fb0-5ce75af184de@users.sourceforge.net> Date: Mon, 29 Aug 2016 13:09:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qtLAZ3w+xEyFbKxU31M/nwfkz1bBol5HoKNG1pkhV12P8qGEDt6 2ApHcU39C2KIEbQmFF/5+BhKKAm1ChbDB+ULJN6sB1tifZQuALV87tqMefrHPlDA+/Kd+nQ pYP+b0C6K/2voX/UdWsFL4Eu8+rC2jUeU0/SZq+NcCjl2OhB1x0LJrHJS+L7zbiotZcNU6Z soJ07Ef3a82Sc6PhpNoLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Nz/sO8UWFgc=:s56UL84RYOb8uKeDJ25hkA Qq5LB7MB6wvszL7Wsdd98CfQmJAo73TE2bycr5qXE2GqSx3vJpBlCnBv7qg5KQl043AuGry87 yX6IBCmE2H/JcVwe20DtAJl0gDW9VAPX6oMMF4zNTtsahlaYapXHXrFU1qeEKc2GC6gI4k5Nd VhTAxaaJMkYq7rUwHXqj24qVXJuC6Xaz2hqsqzBEcPuELb4UcuoWmJNFDL5RH/RO7MWcWiAXv 8K2XL/hWKMXvznWunTOKAoZehAiXOytyYt5A2D+wRGX48KmTccUHCpbBVOYb899Q4WXmRjWAv xyD4DXdmk3mG6V8G8WfwnHwdtQgqJtT9D4Ln/LJjS7MCKEJdOgKRRcEg3Xl9f0nYwxAyYPyWl 1K9AuaTKWWBHzqNuEXnU/sw65pEVBFBQvVAmSWeDc0WNDSVoDR4o+yXREL7FS2t5Wq4jI9KAt 5fx6aMQsDTB5+sJ7H/jfYvjK0Y2q8EsQpum3zGIlcPCSFbfgV7yNXLRPKIJSfFvjF9Hi7HAqb iwu1fgicTb2cO7EbsfI/jcOk7gIz2i/YkH/hBVfCqneDdOUN+wjftwpqvu4zD8XCISMA/w1R1 PIBiU3sUTC8gu6di327gN2CNRgyC/37sRkboCgYsrQdOVw4/p7BErP39wNIfYWkKKfvPkQhlZ t8BCYBCDe0186D/E+39mcYagYRKVN6QSIdOt+HGN6TfvS3x3rEkJApkp52NfMRzMFRkgre4mj gwRcIz5BRfel49hBWJg3lo/8/UCDflTQbfgVAC7C+//X/ejymuvVjEZYxis4KqAHo6rlXjpjc 1xvX6Q0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 29 Aug 2016 11:11:24 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/sysdev/ppc4xx_msi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/ppc4xx_msi.c b/arch/powerpc/sysdev/ppc4xx_msi.c index 8fb8061..0bd5e4b 100644 --- a/arch/powerpc/sysdev/ppc4xx_msi.c +++ b/arch/powerpc/sysdev/ppc4xx_msi.c @@ -89,7 +89,9 @@ static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) if (type == PCI_CAP_ID_MSIX) pr_debug("ppc4xx msi: MSI-X untested, trying anyway.\n"); - msi_data->msi_virqs = kmalloc((msi_irqs) * sizeof(int), GFP_KERNEL); + msi_data->msi_virqs = kmalloc_array(msi_irqs, + sizeof(*msi_data->msi_virqs), + GFP_KERNEL); if (!msi_data->msi_virqs) return -ENOMEM; -- 2.9.3