From: "Bhavesh P. Davda" <bhavesh@avaya.com>
To: <linux-kernel@vger.kernel.org>
Cc: <fischer@norbit.de>, <dahinds@users.sourceforge.net>,
"Marcelo Tosatti" <marcelo@conectiva.com.br>
Subject: [PATCH] AHA152x driver hangs on PCMCIA card eject, kernel 2.4.22-pre6
Date: Tue, 15 Jul 2003 15:56:49 -0600 [thread overview]
Message-ID: <01db01c34b1b$fde04740$6e260987@rnd.avaya.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
Juergen, David; please review this patch, and recommend that Marcelo apply
this patch if you think it is okay... Thanks!
Attached is a patch against linux-2.4.22-pre6, to fix a hang problem when an
Adaptec SlimSCSI (PCMCIA) adapter is ejected from a PCMCIA card reader (e.g.
yenta/TI1225 based).
The fix involves:
1. A change to the common aha152x driver to ignore an interrupt in the
top-half handler if it cannot read valid data from the I/O ports (possibly
due to a bad host-adapter chip or an ejected PCMCIA card). This way, a
shared interrupt handler (e.g. yenta) can pick up the interrupt if the IRQ
is really meant for it. This is where the original hang was taking place;
the aha152x bottom half was getting into an infinite loop, though the
SlimSCSI card had been ejected, and the actual IRQ was meant for yenta.
2. A change to the aha152x_cs stub driver to not use the SCSI error-handling
thread code. The aha152x_cs driver calls scsi_unregister_module() as a
queued timer task when it gets a CS_EVENT_CARD_REMOVAL event, which causes
scsi_unregister_host() to do a down() on a semaphore, calling schedule(),
when executing the timer_bh for the timer.
Thanks!
- Bhavesh
--
Bhavesh P. Davda E-mail : bhavesh@avaya.com
Avaya Inc. Phone/Fax : (303) 538-4438
Room B3-B03, 1300 West 120th Avenue
Westminster, CO 80234
[-- Attachment #2: linux-2.4.22-aha152x.patch --]
[-- Type: application/octet-stream, Size: 1814 bytes --]
diff -Naur linux-2.4.22-pre6/drivers/scsi/aha152x.c linux-2.4.22-bpd/drivers/scsi/aha152x.c
--- linux-2.4.22-pre6/drivers/scsi/aha152x.c 2003-06-13 08:51:36.000000000 -0600
+++ linux-2.4.22-bpd/drivers/scsi/aha152x.c 2003-07-15 14:38:27.000000000 -0600
@@ -1936,6 +1936,23 @@
return;
}
+ /*
+ * Read a couple of registers that are known to not be all 1's. If
+ * we read all 1's (-1), that means that either:
+ * a. The host adapter chip has gone bad, and we cannot control it,
+ * OR
+ * b. The host adapter is a PCMCIA card that has been ejected
+ * In either case, we cannot do anything with the host adapter at
+ * this point in time. So just ignore the interrupt and return.
+ * In the latter case, the interrupt might actually be meant for
+ * someone else sharing this IRQ, and that driver will handle it
+ */
+ rev = GETPORT(REV);
+ dmacntrl0 = GETPORT(DMACNTRL0);
+ if ((rev == 0xFF) && (dmacntrl0 == 0xFF)) {
+ return;
+ }
+
/* no more interrupts from the controller, while we're busy.
INTEN is restored by the BH handler */
CLRBITS(DMACNTRL0, INTEN);
diff -Naur linux-2.4.22-pre6/drivers/scsi/pcmcia/aha152x_stub.c linux-2.4.22-bpd/drivers/scsi/pcmcia/aha152x_stub.c
--- linux-2.4.22-pre6/drivers/scsi/pcmcia/aha152x_stub.c 2001-12-21 10:41:55.000000000 -0700
+++ linux-2.4.22-bpd/drivers/scsi/pcmcia/aha152x_stub.c 2003-07-15 14:41:20.000000000 -0600
@@ -244,6 +244,11 @@
/* Configure card */
driver_template.module = &__this_module;
+ /*
+ * Don't use the SCSI error handling thread. This causes schedule() to
+ * be called from the timer_bh when the AHA152x card is ejected
+ */
+ driver_template.use_new_eh_code = 0;
link->state |= DEV_CONFIG;
tuple.DesiredTuple = CISTPL_CFTABLE_ENTRY;
next reply other threads:[~2003-07-15 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-15 21:56 Bhavesh P. Davda [this message]
2003-07-16 13:16 ` [PATCH] AHA152x driver hangs on PCMCIA card eject, kernel 2.4.22-pre6 Alan Cox
2003-07-17 14:15 ` [PATCH] AHA152x driver hangs on PCMCIA card eject, kernel2.4.22-pre6 Bhavesh P. Davda
2003-07-17 17:55 ` David Hinds
2003-07-17 20:29 ` Bhavesh P. Davda
2003-07-15 22:07 [PATCH] AHA152x driver hangs on PCMCIA card eject, kernel 2.4.22-pre6 Bhavesh P. Davda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01db01c34b1b$fde04740$6e260987@rnd.avaya.com' \
--to=bhavesh@avaya.com \
--cc=dahinds@users.sourceforge.net \
--cc=fischer@norbit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).