From: cang@codeaurora.org
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Evan Green <evgreen@chromium.org>, Janek Kotas <jank@cadence.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: Add command logging infrastructure
Date: Tue, 29 Oct 2019 10:37:45 +0800 [thread overview]
Message-ID: <01eb3c55e35738f2853fbc7175a12eaa@codeaurora.org> (raw)
In-Reply-To: <MN2PR04MB6991C2AF4DDEDD84C7887258FC6B0@MN2PR04MB6991.namprd04.prod.outlook.com>
On 2019-10-23 18:33, Avri Altman wrote:
>>
>> > Add the necessary infrastructure to keep timestamp history of
>> > commands, events and other useful info for debugging complex issues.
>> > This helps in diagnosing events leading upto failure.
>>
>> Why not use tracepoints, for that?
> Ack on Tomas's comment.
> Are there any pieces of information that you need not provided by the
> upiu tracer?
>
> Thanks,
> Avri
In extreme cases, when the UFS runs into bad state, system may crash.
There may not be a chance to collect trace. If trace is not collected
and failure is hard to be reproduced, some command logs prints would be
very helpful to help understand what was going on before we run into
failure.
Thanks,
Can Guo
next prev parent reply other threads:[~2019-10-29 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 5:29 [PATCH v1 1/1] scsi: ufs: Add command logging infrastructure Can Guo
2019-10-23 7:25 ` Winkler, Tomas
2019-10-23 10:33 ` Avri Altman
2019-10-29 2:37 ` cang [this message]
2019-10-29 5:46 ` Bjorn Andersson
2020-01-16 23:03 ` Asutosh Das (asd)
2020-01-17 3:43 ` Bart Van Assche
2020-01-20 18:46 ` Asutosh Das (asd)
2019-10-23 9:33 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01eb3c55e35738f2853fbc7175a12eaa@codeaurora.org \
--to=cang@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).